From e9576bc0d92d2a64b6ca26c40a49f1fe6b24f597 Mon Sep 17 00:00:00 2001 From: Tristan Sloughter Date: Sat, 14 Nov 2020 11:22:37 -0700 Subject: [PATCH] fix add_event macro to call otel_span:add_event/3 --- apps/opentelemetry_api/include/otel_tracer.hrl | 4 ++-- apps/opentelemetry_api/test/opentelemetry_api_SUITE.erl | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/opentelemetry_api/include/otel_tracer.hrl b/apps/opentelemetry_api/include/otel_tracer.hrl index 2f1afb1f..9eb4cab1 100644 --- a/apps/opentelemetry_api/include/otel_tracer.hrl +++ b/apps/opentelemetry_api/include/otel_tracer.hrl @@ -33,8 +33,8 @@ -define(set_attributes(Attributes), otel_span:set_attributes(?current_span_ctx, Attributes)). --define(add_event(Event), - otel_span:add_event(?current_span_ctx, Event)). +-define(add_event(Name, Attributes), + otel_span:add_event(?current_span_ctx, Name, Attributes)). -define(add_events(Events), otel_span:add_events(?current_span_ctx, Events)). diff --git a/apps/opentelemetry_api/test/opentelemetry_api_SUITE.erl b/apps/opentelemetry_api/test/opentelemetry_api_SUITE.erl index 79b2f5d5..96f55069 100644 --- a/apps/opentelemetry_api/test/opentelemetry_api_SUITE.erl +++ b/apps/opentelemetry_api/test/opentelemetry_api_SUITE.erl @@ -115,6 +115,7 @@ update_span_data(_Config) -> ?set_current_span(SpanCtx1), ?set_attribute(<<"key-1">>, <<"value-1">>), + ?add_event(<<"event-1">>, [{<<"attr-1">>, <<"value-1">>}]), Events = opentelemetry:events([{opentelemetry:timestamp(), <<"timed-event-name">>, []}]),