Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otelgrpc] Do not panic for nil instruments #4875

Merged
merged 6 commits into from
Jan 30, 2024

Use noop pkg hist impls

b02d422
Select commit
Loading
Failed to load commit list.
Merged

[otelgrpc] Do not panic for nil instruments #4875

Use noop pkg hist impls
b02d422
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2024 in 1s

81.5% (+0.1%) compared to ef8063b

View this Pull Request on Codecov

81.5% (+0.1%) compared to ef8063b

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef8063b) 81.3% compared to head (b02d422) 81.5%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4875     +/-   ##
=======================================
+ Coverage   81.3%   81.5%   +0.1%     
=======================================
  Files        151     151             
  Lines      10894   10904     +10     
=======================================
+ Hits        8866    8891     +25     
+ Misses      1869    1859     -10     
+ Partials     159     154      -5     
Files Coverage Δ
...entation/google.golang.org/grpc/otelgrpc/config.go 87.8% <100.0%> (+18.2%) ⬆️