Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown underlying span exporter while shutting down BatchSpanProcessor #1443

Merged
merged 5 commits into from
Jan 14, 2021

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Jan 8, 2021

Resolves #1423

@XSAM XSAM force-pushed the fix/batch-span-processor branch 2 times, most recently from 13b72ab to 76d4e5e Compare January 8, 2021 12:29
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #1443 (76d9c9a) into master (dfece3d) will decrease coverage by 0.0%.
The diff coverage is 33.3%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1443     +/-   ##
========================================
- Coverage    78.9%   78.9%   -0.1%     
========================================
  Files         128     128             
  Lines        6664    6666      +2     
========================================
  Hits         5263    5263             
- Misses       1147    1148      +1     
- Partials      254     255      +1     
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 78.8% <33.3%> (-1.6%) ⬇️

CHANGELOG.md Outdated Show resolved Hide resolved
XSAM and others added 2 commits January 12, 2021 12:26
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
@Aneurysm9 Aneurysm9 merged commit c29c6fd into open-telemetry:master Jan 14, 2021
@XSAM XSAM deleted the fix/batch-span-processor branch February 16, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BatchSpanProcessor does not Shutdown underlying export.SpanExporter
3 participants