Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the AsType functions not panic #3489

merged 5 commits into from Nov 25, 2022


Copy link

Fixes #3488

This fixes any reflection panics related to calling AsTypeSlice() on attribute Values.

Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #3489 (a69e102) into main (1f5e6ad) will increase coverage by 0.0%.
The diff coverage is 85.7%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3489   +/-   ##
  Coverage   77.8%   77.9%           
  Files        165     165           
  Lines      11614   11634   +20     
+ Hits        9044    9066   +22     
+ Misses      2374    2372    -2     
  Partials     196     196           
Impacted Files Coverage Δ
attribute/value.go 91.2% <85.7%> (+1.6%) ⬆️
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) ⬆️

Copy link

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a change log entry describing the big fix.

@MrAlias MrAlias added the bug Something isn't working label Nov 22, 2022
@MrAlias MrAlias added this to the Release v1.12.0 milestone Nov 22, 2022
@MrAlias MrAlias merged commit d7b3115 into open-telemetry:main Nov 25, 2022
20 checks passed
@MadVikingGod MadVikingGod deleted the mvg/attribute-no-panic branch February 21, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

Incorrect attribute Value casts panic.
4 participants