Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exporter): Jaeger and Zipkin exporter use logr as the logging interface #3500

merged 8 commits into from Dec 8, 2022


Copy link

@aniaan aniaan commented Nov 30, 2022

close: #3497

Please help to see if this change is appropriate, cc @MadVikingGod

…gr` as the logging interface, and add the WithLogr option
Copy link

linux-foundation-easycla bot commented Nov 30, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: aniaan / name: aniaan (eb27827)

Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #3500 (b3aa39a) into main (8644a79) will decrease coverage by 0.0%.
The diff coverage is 55.5%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3500     +/-   ##
- Coverage   77.9%   77.9%   -0.1%     
  Files        164     164             
  Lines      11699   11703      +4     
+ Hits        9119    9121      +2     
- Misses      2385    2387      +2     
  Partials     195     195             
Impacted Files Coverage Δ
exporters/jaeger/agent.go 72.1% <ø> (ø)
exporters/jaeger/uploader.go 47.5% <0.0%> (-0.7%) ⬇️
exporters/jaeger/reconnecting_udp_client.go 89.9% <33.3%> (ø)
exporters/zipkin/zipkin.go 67.3% <100.0%> (+0.6%) ⬆️

Copy link

@MadVikingGod MadVikingGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


exporters/zipkin/zipkin.go Outdated Show resolved Hide resolved
exporters/jaeger/uploader.go Show resolved Hide resolved
@aniaan aniaan requested a review from Aneurysm9 December 2, 2022 06:26 Outdated Show resolved Hide resolved
exporters/zipkin/zipkin.go Outdated Show resolved Hide resolved
@aniaan aniaan requested review from MrAlias and removed request for Aneurysm9 December 2, 2022 15:50
@MrAlias MrAlias merged commit 4e76347 into open-telemetry:main Dec 8, 2022
19 of 20 checks passed
@MrAlias MrAlias added this to the Release v1.12.0 milestone Jan 27, 2023
@MrAlias MrAlias mentioned this pull request Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Exporter: WithLogger uses the interface to replace the standard library logger
5 participants