fix(sdk/trace): return spec-compliant TraceIdRatioBased description by ash2k · Pull Request #8027 · open-telemetry/opentelemetry-go

ash2k · 2026-03-09T03:55:33Z

Optimize performance when sampling is disabled - no need to calculate fraction based on trace id (in traceIDRatioSampler) if fraction is zero.

codecov · 2026-03-09T03:57:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.5%. Comparing base (f4da59e) to head (9ce33a4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #8027   +/-   ##
=====================================
  Coverage   81.5%   81.5%           
=====================================
  Files        304     304           
  Lines      23438   23448   +10     
=====================================
+ Hits       19124   19133    +9     
  Misses      3927    3927           
- Partials     387     388    +1

Files with missing lines	Coverage Δ
sdk/trace/sampling.go	`100.0% <100.0%> (ø)`

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ash2k · 2026-03-09T04:51:35Z

Some strange unrelated failures in tests.

dashpole · 2026-03-10T15:53:24Z

@ash2k Can you add a test to make sure the descriptions of each are correct?

FYI @open-telemetry/go-maintainers this changes the string result of calling Description() on TraceIDRatioBased(1) from "AlwaysOnSampler" to "TraceIDRatioBased{1}". This is required by the Spec:

Description MUST return a string of the form "TraceIdRatioBased{RATIO}" with RATIO replaced with the Sampler instance’s trace sampling ratio represented as a decimal number.

I think this is unlikely to break users, and is something we should do to make sure we comply with the specification.

@ash2k can you make sure that the changed Description return value is called out in the changelog in the Changed section?

ash2k · 2026-03-11T07:02:33Z

I've made the requested changes, PTAL.

Co-authored-by: David Ashpole <dashpole@google.com>

Release issue: #8127 ## Added - Add `IsRandom` and `WithRandom` on `TraceFlags`, and `IsRandom` on `SpanContext` in `go.opentelemetry.io/otel/trace` for [W3C Trace Context Level 2 Random Trace ID Flag](https://www.w3.org/TR/trace-context-2/#random-trace-id-flag) support. (#8012) - Add service detection with `WithService` in `go.opentelemetry.io/otel/sdk/resource`. (#7642) - Add `DefaultWithContext` and `EnvironmentWithContext` in `go.opentelemetry.io/otel/sdk/resource` to support plumbing `context.Context` through default and environment detectors. (#8051) - Support attributes with empty value (`attribute.EMPTY`) in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`. (#8038) - Support attributes with empty value (`attribute.EMPTY`) in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc`. (#8038) - Support attributes with empty value (`attribute.EMPTY`) in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc`. (#8038) - Support attributes with empty value (`attribute.EMPTY`) in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`. (#8038) - Support attributes with empty value (`attribute.EMPTY`) in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. (#8038) - Support attributes with empty value (`attribute.EMPTY`) in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#8038) - Support attributes with empty value (`attribute.EMPTY`) in `go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest`. (#8038) - Add support for per-series start time tracking for cumulative metrics in `go.opentelemetry.io/otel/sdk/metric`. Set `OTEL_GO_X_PER_SERIES_START_TIMESTAMPS=true` to enable. (#8060) - Add `WithCardinalityLimitSelector` for metric reader for configuring cardinality limits specific to the instrument kind. (#7855) ## Changed - Introduce the `EMPTY` Type in `go.opentelemetry.io/otel/attribute` to reflect that an empty value is now a valid value, with `INVALID` remaining as a deprecated alias of `EMPTY`. (#8038) - Refactor slice handling in `go.opentelemetry.io/otel/attribute` to optimize short slice values with fixed-size fast paths. (#8039) - Improve performance of span metric recording in `go.opentelemetry.io/otel/sdk/trace` by returning early if self-observability is not enabled. (#8067) - Improve formatting of metric data diffs in `go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest`. (#8073) ## Deprecated - Deprecate `INVALID` in `go.opentelemetry.io/otel/attribute`. Use `EMPTY` instead. (#8038) ## Fixed - Return spec-compliant `TraceIdRatioBased` description. This is a breaking behavioral change, but it is necessary to make the implementation [spec-compliant](https://opentelemetry.io/docs/specs/otel/trace/sdk/#traceidratiobased). (#8027) - Fix a race condition in `go.opentelemetry.io/otel/sdk/metric` where the lastvalue aggregation could collect the value 0 even when no zero-value measurements were recorded. (#8056) - Limit HTTP response body to 4 MiB in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp` to mitigate excessive memory usage caused by a misconfigured or malicious server. Responses exceeding the limit are treated as non-retryable errors. (#8108) - Limit HTTP response body to 4 MiB in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp` to mitigate excessive memory usage caused by a misconfigured or malicious server. Responses exceeding the limit are treated as non-retryable errors. (#8108) - Limit HTTP response body to 4 MiB in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp` to mitigate excessive memory usage caused by a misconfigured or malicious server. Responses exceeding the limit are treated as non-retryable errors. (#8108) - `WithHostID` detector in `go.opentelemetry.io/otel/sdk/resource` to use full path for `kenv` command on BSD. (#8113) - Fix missing `request.GetBody` in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp` to correctly handle HTTP2 GOAWAY frame. (#8096) --------- Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

ash2k requested review from MrAlias, XSAM, dashpole, dmathieu, flc1125 and pellared as code owners March 9, 2026 03:55

flc1125 reviewed Mar 9, 2026

View reviewed changes

Comment thread sdk/trace/sampling.go Outdated

This comment was marked as outdated.

Sign in to view

ash2k force-pushed the never-sample branch 2 times, most recently from 84f93c4 to d3b9252 Compare March 10, 2026 06:20

flc1125 reviewed Mar 11, 2026

View reviewed changes

Comment thread sdk/trace/sampling.go

Comment thread sdk/trace/sampling.go Outdated

Comment thread sdk/trace/sampling.go Outdated

ash2k changed the title ~~chore(sdk/trace): use NeverSample() when sampling is at or below zero~~ fix(sdk/trace): return spec-compliant TraceIdRatioBased description Mar 11, 2026

ash2k force-pushed the never-sample branch from d3b9252 to d7db9e1 Compare March 11, 2026 07:00

fix(sdk/trace): return spec-compliant TraceIdRatioBased description

ab61e85

ash2k force-pushed the never-sample branch from d7db9e1 to ab61e85 Compare March 11, 2026 07:02

dashpole reviewed Mar 11, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

dashpole approved these changes Mar 11, 2026

View reviewed changes

flc1125 approved these changes Mar 11, 2026

View reviewed changes

Update CHANGELOG.md

fc322a0

Co-authored-by: David Ashpole <dashpole@google.com>

dmathieu approved these changes Mar 12, 2026

View reviewed changes

Merge branch 'main' into never-sample

9ce33a4

dmathieu merged commit ddd2b0e into open-telemetry:main Mar 12, 2026
34 checks passed

ash2k deleted the never-sample branch March 12, 2026 09:18

pellared added this to the v1.43.0 milestone Apr 1, 2026

dmathieu mentioned this pull request Apr 2, 2026

Release v1.43.0 / v0.65.0 / v0.19.0 #8128

Merged

liggitt mentioned this pull request Apr 9, 2026

Bump otel to 1.43.0 and contrib to 0.68.0 kubernetes/kubernetes#138192

Merged

GowthamShanmugam mentioned this pull request Apr 18, 2026

chore(deps): bump go.opentelemetry.io/otel/sdk from 1.39.0 to 1.43.0 in /kube-rbac-proxy opendatahub-io/kube-auth-proxy#79

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(sdk/trace): return spec-compliant TraceIdRatioBased description#8027

fix(sdk/trace): return spec-compliant TraceIdRatioBased description#8027
dmathieu merged 3 commits into
open-telemetry:mainfrom
ash2k:never-sample

ash2k commented Mar 9, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Mar 9, 2026 •

edited

Loading

Uh oh!

ash2k commented Mar 9, 2026

Uh oh!

Uh oh!

This comment was marked as outdated.

dashpole commented Mar 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ash2k commented Mar 11, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ash2k commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ash2k commented Mar 9, 2026

Uh oh!

Uh oh!

This comment was marked as outdated.

dashpole commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ash2k commented Mar 11, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ash2k commented Mar 9, 2026 •

edited

Loading

codecov Bot commented Mar 9, 2026 •

edited

Loading

dashpole commented Mar 10, 2026 •

edited

Loading