Skip to content

Use an absolute path when calling bsd kenv#8113

Merged
pellared merged 4 commits into
open-telemetry:mainfrom
dmathieu:absolute-kenv-path
Apr 1, 2026
Merged

Use an absolute path when calling bsd kenv#8113
pellared merged 4 commits into
open-telemetry:mainfrom
dmathieu:absolute-kenv-path

Conversation

@dmathieu
Copy link
Copy Markdown
Member

@dmathieu dmathieu commented Mar 31, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.7%. Comparing base (290024c) to head (85422b0).
⚠️ Report is 66 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8113     +/-   ##
=======================================
- Coverage   81.7%   81.7%   -0.1%     
=======================================
  Files        308     308             
  Lines      23691   23691             
=======================================
- Hits       19374   19372      -2     
- Misses      3933    3935      +2     
  Partials     384     384
Files with missing lines Coverage Δ
sdk/resource/host_id.go 96.7% <100.0%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu marked this pull request as ready for review March 31, 2026 08:12
pellared added 2 commits April 1, 2026 10:57
@pellared
Improve comments in host_id.go
adcf3ec 
Updated comments for clarity and formatting consistency.
@pellared
Merge branch 'main' into absolute-kenv-path
85422b0
@pellared
Copy link
Copy Markdown
Member

pellared commented Apr 1, 2026

image

Double-checked the location.
Merging as trivial fix.

@pellared pellared merged commit 35214b6 into open-telemetry:main Apr 1, 2026
33 checks passed
@dmathieu dmathieu deleted the absolute-kenv-path branch April 1, 2026 09:13
@pellared pellared added this to the v1.43.0 milestone Apr 1, 2026
@dmathieu dmathieu mentioned this pull request Apr 2, 2026
Merged
dmathieu added a commit that referenced this pull request Apr 3, 2026
@dmathieu @MrAlias
Release v1.43.0 / v0.65.0 / v0.19.0 (#8128)
9276201 
Release issue:
#8127

## Added

- Add `IsRandom` and `WithRandom` on `TraceFlags`, and `IsRandom` on
`SpanContext` in `go.opentelemetry.io/otel/trace`
for [W3C Trace Context Level 2 Random Trace ID
Flag](https://www.w3.org/TR/trace-context-2/#random-trace-id-flag)
support. (#8012)
- Add service detection with `WithService` in
`go.opentelemetry.io/otel/sdk/resource`. (#7642)
- Add `DefaultWithContext` and `EnvironmentWithContext` in
`go.opentelemetry.io/otel/sdk/resource` to support plumbing
`context.Context` through default and environment detectors. (#8051)
- Support attributes with empty value (`attribute.EMPTY`) in
`go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`.
(#8038)
- Support attributes with empty value (`attribute.EMPTY`) in
`go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc`.
(#8038)
- Support attributes with empty value (`attribute.EMPTY`) in
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc`. (#8038)
- Support attributes with empty value (`attribute.EMPTY`) in
`go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`.
(#8038)
- Support attributes with empty value (`attribute.EMPTY`) in
`go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`.
(#8038)
- Support attributes with empty value (`attribute.EMPTY`) in
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#8038)
- Support attributes with empty value (`attribute.EMPTY`) in
`go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest`. (#8038)
- Add support for per-series start time tracking for cumulative metrics
in `go.opentelemetry.io/otel/sdk/metric`.
  Set `OTEL_GO_X_PER_SERIES_START_TIMESTAMPS=true` to enable. (#8060)
- Add `WithCardinalityLimitSelector` for metric reader for configuring
cardinality limits specific to the instrument kind. (#7855)

## Changed

- Introduce the `EMPTY` Type in `go.opentelemetry.io/otel/attribute` to
reflect that an empty value is now a valid value, with `INVALID`
remaining as a deprecated alias of `EMPTY`. (#8038)
- Refactor slice handling in `go.opentelemetry.io/otel/attribute` to
optimize short slice values with fixed-size fast paths. (#8039)
- Improve performance of span metric recording in
`go.opentelemetry.io/otel/sdk/trace` by returning early if
self-observability is not enabled. (#8067)
- Improve formatting of metric data diffs in
`go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest`. (#8073)

## Deprecated

- Deprecate `INVALID` in `go.opentelemetry.io/otel/attribute`. Use
`EMPTY` instead. (#8038)

## Fixed

- Return spec-compliant `TraceIdRatioBased` description. This is a
breaking behavioral change, but it is necessary to
make the implementation
[spec-compliant](https://opentelemetry.io/docs/specs/otel/trace/sdk/#traceidratiobased).
(#8027)
- Fix a race condition in `go.opentelemetry.io/otel/sdk/metric` where
the lastvalue aggregation could collect the value 0 even when no
zero-value measurements were recorded. (#8056)
- Limit HTTP response body to 4 MiB in
`go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp` to
mitigate excessive memory usage caused by a misconfigured or malicious
server.
Responses exceeding the limit are treated as non-retryable errors.
(#8108)
- Limit HTTP response body to 4 MiB in
`go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp` to
mitigate excessive memory usage caused by a misconfigured or malicious
server.
Responses exceeding the limit are treated as non-retryable errors.
(#8108)
- Limit HTTP response body to 4 MiB in
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp` to
mitigate excessive memory usage caused by a misconfigured or malicious
server.
Responses exceeding the limit are treated as non-retryable errors.
(#8108)
- `WithHostID` detector in `go.opentelemetry.io/otel/sdk/resource` to
use full path for `kenv` command on BSD. (#8113)
- Fix missing `request.GetBody` in
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp` to
correctly handle HTTP2 GOAWAY frame. (#8096)

---------

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@EdSchouten
Copy link
Copy Markdown

EdSchouten commented Apr 9, 2026

Why not just invoke the kenv() system call directly?

@dmathieu
Copy link
Copy Markdown
Member Author

dmathieu commented Apr 9, 2026

Because of GHSA-hfvc-g4fc-pqhx

@EdSchouten
Copy link
Copy Markdown

EdSchouten commented Apr 9, 2026

I don't think that answers my question. I'm stating that you could remove the calls to the kenv binary entirely, and simply call the kenv() function to do what you want.

@dmathieu
Copy link
Copy Markdown
Member Author

dmathieu commented Apr 9, 2026

Using syscall.Syscall is not that straightforward, as we'd then have to parse its result, and it requires memory unsafe code.

@EdSchouten
Copy link
Copy Markdown

EdSchouten commented Apr 9, 2026

I'm fairly sure the maintainers of golang.org/x/sys/unix are willing to take patches to add a type-safe binding for kenv().

@dmathieu
Copy link
Copy Markdown
Member Author

dmathieu commented Apr 9, 2026

Feel free to lobby them to do so, and once it's available in all supported Go versions, we'll be happy to switch to this.

This was referenced Apr 16, 2026
Merged
Open
@duckhawk duckhawk mentioned this pull request Apr 21, 2026
Merged
shaked-seal pushed a commit to ali-security/opentelemetry-go-7929 that referenced this pull request May 6, 2026
@dmathieu @pellared @shaked-seal
Use an absolute path when calling bsd kenv (open-telemetry#8113)
85f6959 
Co-authored-by: Robert Pająk <pellared@hotmail.com>
shaked-seal pushed a commit to ali-security/opentelemetry-go-7929 that referenced this pull request May 6, 2026
@dmathieu @pellared @shaked-seal
Use an absolute path when calling bsd kenv (open-telemetry#8113)
0f5ec25 
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pellared pellared pellared approved these changes

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@flc1125 flc1125 Awaiting requested review from flc1125 flc1125 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.43.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dmathieu @pellared @EdSchouten