From 87458065117a87fa079c3deb39be32aafc9fdccb Mon Sep 17 00:00:00 2001 From: Lauri Tulmin Date: Wed, 1 May 2024 13:45:10 +0300 Subject: [PATCH] add comment --- .../instrumentation/reactor/v3_1/BaseMonoWithSpanTest.java | 1 + .../instrumentation/reactor/v3_1/ReactorCoreTest.java | 2 ++ 2 files changed, 3 insertions(+) diff --git a/instrumentation/reactor/reactor-3.1/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/reactor/v3_1/BaseMonoWithSpanTest.java b/instrumentation/reactor/reactor-3.1/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/reactor/v3_1/BaseMonoWithSpanTest.java index 50b800417e8d..2e0b3b2f7ecf 100644 --- a/instrumentation/reactor/reactor-3.1/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/reactor/v3_1/BaseMonoWithSpanTest.java +++ b/instrumentation/reactor/reactor-3.1/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/reactor/v3_1/BaseMonoWithSpanTest.java @@ -88,6 +88,7 @@ void nested() { span -> span.hasName("inner-manual") .hasKind(SpanKind.INTERNAL) + // earliest tested and latest version behave differently .hasParent(trace.getSpan(Boolean.getBoolean("testLatestDeps") ? 0 : 1)) .hasAttributes(Attributes.empty()))); } diff --git a/instrumentation/reactor/reactor-3.1/library/src/test/java/io/opentelemetry/instrumentation/reactor/v3_1/ReactorCoreTest.java b/instrumentation/reactor/reactor-3.1/library/src/test/java/io/opentelemetry/instrumentation/reactor/v3_1/ReactorCoreTest.java index 1d8b1d485684..cbc696656ab3 100644 --- a/instrumentation/reactor/reactor-3.1/library/src/test/java/io/opentelemetry/instrumentation/reactor/v3_1/ReactorCoreTest.java +++ b/instrumentation/reactor/reactor-3.1/library/src/test/java/io/opentelemetry/instrumentation/reactor/v3_1/ReactorCoreTest.java @@ -167,6 +167,8 @@ void nestedNonBlocking() { () -> Mono.defer( () -> { + // earliest tested and latest version behave differently + // in latest dep test current span is "parent" not "middle" if (!testLatestDeps) { Span.current().setAttribute("middle", "foo"); }