PlayWS strict context check #4365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
26 tasks
iNikem
reviewed
Oct 13, 2021
| @Advice.OnMethodEnter(suppress = Throwable.class) | ||
| public static Scope onEnter() { | ||
| if (Java8BytecodeBridge.currentContext() != Java8BytecodeBridge.rootContext()) { | ||
| return Java8BytecodeBridge.rootContext().makeCurrent(); |
There was a problem hiding this comment.
I believe it forcefully removes the current context for while the method executes; this way preventing the context leaking into a (potentially long-running) task that's started there.
There was a problem hiding this comment.
Will everybody understand that in a year while reading this code? :)
There was a problem hiding this comment.
Let's wait a year and see 🤣
But yeah, a comment here explaining why we're doing such a thing would be invaluable.
mateuszrzeszutek
approved these changes
Oct 13, 2021
| @Advice.OnMethodEnter(suppress = Throwable.class) | ||
| public static Scope onEnter() { | ||
| if (Java8BytecodeBridge.currentContext() != Java8BytecodeBridge.rootContext()) { | ||
| return Java8BytecodeBridge.rootContext().makeCurrent(); |
There was a problem hiding this comment.
I believe it forcefully removes the current context for while the method executes; this way preventing the context leaking into a (potentially long-running) task that's started there.
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* PlayWS strict context check * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3916