Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link should be implemented in Span, not SpanData #1714

Closed
anuraaga opened this issue Sep 26, 2020 · 2 comments
Closed

Link should be implemented in Span, not SpanData #1714

anuraaga opened this issue Sep 26, 2020 · 2 comments
Labels
Feature Request Suggest an idea for this project

Comments

@anuraaga
Copy link
Contributor

While working on #1712 I found it very surprising to find Link only really exists as part of SpanData. I think the span data model should be implemented without being conjoined to SpanData, an export concept.
@anuraaga anuraaga added the Feature Request Suggest an idea for this project label Sep 26, 2020
@jkwatson
Copy link
Contributor

jkwatson commented Mar 5, 2021

@anuraaga do you still think it's important to have a Link interface in the API at this point?

@anuraaga
Copy link
Contributor Author

anuraaga commented Mar 6, 2021

Nope think this is fine

@anuraaga anuraaga closed this as completed Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anuraaga @jkwatson