New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some cleanup in span land. #2062
Conversation
jkwatson
commented
Nov 11, 2020
- Clean up the SpanBuilder javadoc to match the current APIs
- Scrub mentions of canonical status code
- Deprecate the getCanonicalCode method on SpanBuilder and replace with getStatusCode
Codecov Report
@@ Coverage Diff @@
## master #2062 +/- ##
=========================================
Coverage ? 85.36%
Complexity ? 2026
=========================================
Files ? 231
Lines ? 7849
Branches ? 830
=========================================
Hits ? 6700
Misses ? 838
Partials ? 311
Continue to review full report at Codecov.
|
*/ | ||
StatusCode getCanonicalCode(); | ||
@Deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we currently still have enough other breaking changes that it is OK to completely remove this. It's just a renaming, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've started thinking that since we're moving to a 2-week release cycle, that it would be more friendly to end users to introduce deprecations that are then deleted in the following release. We discussed this at the SIG meeting this morning, and it was generally agreed to. This seemed like a easy way to ease into the practice. :)
...cing/src/test/java/io/opentelemetry/sdk/trace/testbed/errorreporting/ErrorReportingTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for scrubbing!
* Clean up the SpanBuilder javadoc to match the current APIs * Scrub mentions of canonical status code * Deprecate the getCanonicalCode method on SpanBuilder and replace with getStatusCode
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
3957cc6
to
3e10818
Compare