From 93e29611a200dafdda862f15b5257e0af46f44bb Mon Sep 17 00:00:00 2001 From: Amir Blum Date: Sat, 18 May 2024 10:07:12 +0300 Subject: [PATCH] fix: some fixes from code review --- packages/winston-transport/README.md | 2 +- plugins/node/instrumentation-kafkajs/README.md | 2 +- plugins/node/instrumentation-kafkajs/src/instrumentation.ts | 2 +- plugins/node/instrumentation-socket.io/README.md | 2 +- plugins/node/opentelemetry-instrumentation-koa/README.md | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/winston-transport/README.md b/packages/winston-transport/README.md index 977d2da610..73b360ad95 100644 --- a/packages/winston-transport/README.md +++ b/packages/winston-transport/README.md @@ -51,7 +51,7 @@ const logger = winston.createLogger({ ### Supported versions -Winston `3.x` +- [`winston`](https://www.npmjs.com/package/winston) versions `>=3.0.0 <4` ## Useful links diff --git a/plugins/node/instrumentation-kafkajs/README.md b/plugins/node/instrumentation-kafkajs/README.md index 9f00d430e2..a5f54ee2ee 100644 --- a/plugins/node/instrumentation-kafkajs/README.md +++ b/plugins/node/instrumentation-kafkajs/README.md @@ -17,7 +17,7 @@ npm install --save @opentelemetry/instrumentation-kafkajs ### Supported versions -- `<3.0.0` +- [`kafkajs`](https://www.npmjs.com/package/kafkajs) versions `>=0.1.0 <3` ## Usage diff --git a/plugins/node/instrumentation-kafkajs/src/instrumentation.ts b/plugins/node/instrumentation-kafkajs/src/instrumentation.ts index 09762e8e6f..edb40c4079 100644 --- a/plugins/node/instrumentation-kafkajs/src/instrumentation.ts +++ b/plugins/node/instrumentation-kafkajs/src/instrumentation.ts @@ -72,7 +72,7 @@ export class KafkaJsInstrumentation extends InstrumentationBase { const module = new InstrumentationNodeModuleDefinition( 'kafkajs', - ['< 3'], + ['>=0.1.0 <3'], (moduleExports: typeof kafkaJs) => { unpatch(moduleExports); this._wrap( diff --git a/plugins/node/instrumentation-socket.io/README.md b/plugins/node/instrumentation-socket.io/README.md index cf35b83756..fd30b8cbd6 100644 --- a/plugins/node/instrumentation-socket.io/README.md +++ b/plugins/node/instrumentation-socket.io/README.md @@ -17,7 +17,7 @@ npm install --save @opentelemetry/instrumentation-socket.io ## Supported Versions -- [socket.io](https://www.npmjs.com/package/socket.io) versions `>=2 <5` +- [socket.io](https://www.npmjs.com/package/socket.io) versions `>=2.0.0 <5` ## Usage diff --git a/plugins/node/opentelemetry-instrumentation-koa/README.md b/plugins/node/opentelemetry-instrumentation-koa/README.md index ea837e5486..2fb3888511 100644 --- a/plugins/node/opentelemetry-instrumentation-koa/README.md +++ b/plugins/node/opentelemetry-instrumentation-koa/README.md @@ -22,7 +22,7 @@ npm install --save @opentelemetry/instrumentation-koa ### Supported Versions - [`koa`](https://www.npmjs.com/package/koa) versions `^2.0.0` -- [`@koa/router`] versions `>=8.0.0` +- [`@koa/router`](https://www.npmjs.com/package/@koa/router) versions `>=8.0.0` ## Usage