From f6a075be3204befa970cd4b7d6101419ee5d562e Mon Sep 17 00:00:00 2001 From: Martin Kuba Date: Mon, 25 Mar 2024 09:35:20 -0700 Subject: [PATCH] Rename EventEmitter to EventLogger in the Events API (#4568) * renamed EventEmitter to EventLogger * updated changelog * renamed remaining references to emitter * lint --- experimental/CHANGELOG.md | 1 + experimental/packages/api-events/README.md | 18 +++---- ...NoopEventEmitter.ts => NoopEventLogger.ts} | 4 +- ...Provider.ts => NoopEventLoggerProvider.ts} | 20 +++---- .../packages/api-events/src/api/events.ts | 46 ++++++++-------- experimental/packages/api-events/src/index.ts | 6 +-- .../api-events/src/internal/global-utils.ts | 4 +- .../types/{EventEmitter.ts => EventLogger.ts} | 2 +- ...mitterOptions.ts => EventLoggerOptions.ts} | 2 +- ...tterProvider.ts => EventLoggerProvider.ts} | 24 ++++----- .../packages/api-events/test/api/api.test.ts | 54 +++++++++---------- .../api-events/test/internal/global.test.ts | 38 ++++++------- ....ts => noop-event-logger-provider.test.ts} | 18 +++---- ...tter.test.ts => noop-event-logger.test.ts} | 14 ++--- 14 files changed, 124 insertions(+), 127 deletions(-) rename experimental/packages/api-events/src/{NoopEventEmitter.ts => NoopEventLogger.ts} (86%) rename experimental/packages/api-events/src/{NoopEventEmitterProvider.ts => NoopEventLoggerProvider.ts} (56%) rename experimental/packages/api-events/src/types/{EventEmitter.ts => EventLogger.ts} (96%) rename experimental/packages/api-events/src/types/{EventEmitterOptions.ts => EventLoggerOptions.ts} (95%) rename experimental/packages/api-events/src/types/{EventEmitterProvider.ts => EventLoggerProvider.ts} (51%) rename experimental/packages/api-events/test/noop-implementations/{noop-event-emitter-provider.test.ts => noop-event-logger-provider.test.ts} (62%) rename experimental/packages/api-events/test/noop-implementations/{noop-event-emitter.test.ts => noop-event-logger.test.ts} (65%) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index 34a7671491..62588e6877 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -20,6 +20,7 @@ All notable changes to experimental packages in this project will be documented * `compression` * was used internally to keep track of the compression to use but was unintentionally exposed to the users. It allowed to read and write the value, writing, however, would have no effect. * feat(api-events)!: removed domain from the Events API [#4569](https://github.com/open-telemetry/opentelemetry-js/pull/4569) +* fix(events-api)!: renamed EventEmitter to EventLogger in the Events API [#4569](https://github.com/open-telemetry/opentelemetry-js/pull/4568) ### :rocket: (Enhancement) diff --git a/experimental/packages/api-events/README.md b/experimental/packages/api-events/README.md index 1b8d168f62..d2ce3fea36 100644 --- a/experimental/packages/api-events/README.md +++ b/experimental/packages/api-events/README.md @@ -28,18 +28,18 @@ If you are writing an instrumentation library, or prefer to call the API methods ```javascript const api = require("@opentelemetry/api-events"); -/* A specific implementation of EventEmitterProvider comes from an SDK */ -const eventEmitterProvider = createEventEmitterProvider(); +/* A specific implementation of EventLoggerProvider comes from an SDK */ +const eventLoggerProvider = createEventLoggerProvider(); -/* Initialize EventEmitterProvider */ -api.events.setGlobalEventEmitterProvider(eventEmitterProvider); -/* returns eventEmitterProvider (no-op if a working provider has not been initialized) */ -api.events.getEventEmitterProvider(); -/* returns an event emitter from the registered global event emitter provider (no-op if a working provider has not been initialized) */ -const eventEmitter = api.events.getEventEmitter(name, version); +/* Initialize EventLoggerProvider */ +api.events.setGlobalEventLoggerProvider(eventLoggerProvider); +/* returns eventLoggerProvider (no-op if a working provider has not been initialized) */ +api.events.getEventLoggerProvider(); +/* returns an event logger from the registered global event logger provider (no-op if a working provider has not been initialized) */ +const eventLogger = api.events.getEventLogger(name, version); // logging an event in an instrumentation library -eventEmitter.emit({ name: 'event-name' }); +eventLogger.emit({ name: 'event-name' }); ``` ## Useful links diff --git a/experimental/packages/api-events/src/NoopEventEmitter.ts b/experimental/packages/api-events/src/NoopEventLogger.ts similarity index 86% rename from experimental/packages/api-events/src/NoopEventEmitter.ts rename to experimental/packages/api-events/src/NoopEventLogger.ts index b576e02bcf..4ee4d7e23a 100644 --- a/experimental/packages/api-events/src/NoopEventEmitter.ts +++ b/experimental/packages/api-events/src/NoopEventLogger.ts @@ -14,9 +14,9 @@ * limitations under the License. */ -import { EventEmitter } from './types/EventEmitter'; +import { EventLogger } from './types/EventLogger'; import { Event } from './types/Event'; -export class NoopEventEmitter implements EventEmitter { +export class NoopEventLogger implements EventLogger { emit(_event: Event): void {} } diff --git a/experimental/packages/api-events/src/NoopEventEmitterProvider.ts b/experimental/packages/api-events/src/NoopEventLoggerProvider.ts similarity index 56% rename from experimental/packages/api-events/src/NoopEventEmitterProvider.ts rename to experimental/packages/api-events/src/NoopEventLoggerProvider.ts index 4d33536ac5..4fa5630b67 100644 --- a/experimental/packages/api-events/src/NoopEventEmitterProvider.ts +++ b/experimental/packages/api-events/src/NoopEventLoggerProvider.ts @@ -14,19 +14,19 @@ * limitations under the License. */ -import { EventEmitterProvider } from './types/EventEmitterProvider'; -import { EventEmitter } from './types/EventEmitter'; -import { EventEmitterOptions } from './types/EventEmitterOptions'; -import { NoopEventEmitter } from './NoopEventEmitter'; +import { EventLoggerProvider } from './types/EventLoggerProvider'; +import { EventLogger } from './types/EventLogger'; +import { EventLoggerOptions } from './types/EventLoggerOptions'; +import { NoopEventLogger } from './NoopEventLogger'; -export class NoopEventEmitterProvider implements EventEmitterProvider { - getEventEmitter( +export class NoopEventLoggerProvider implements EventLoggerProvider { + getEventLogger( _name: string, _version?: string | undefined, - _options?: EventEmitterOptions | undefined - ): EventEmitter { - return new NoopEventEmitter(); + _options?: EventLoggerOptions | undefined + ): EventLogger { + return new NoopEventLogger(); } } -export const NOOP_EVENT_EMITTER_PROVIDER = new NoopEventEmitterProvider(); +export const NOOP_EVENT_LOGGER_PROVIDER = new NoopEventLoggerProvider(); diff --git a/experimental/packages/api-events/src/api/events.ts b/experimental/packages/api-events/src/api/events.ts index 0888bd684b..c5a631c8fd 100644 --- a/experimental/packages/api-events/src/api/events.ts +++ b/experimental/packages/api-events/src/api/events.ts @@ -20,10 +20,10 @@ import { _global, makeGetter, } from '../internal/global-utils'; -import { EventEmitterProvider } from '../types/EventEmitterProvider'; -import { NOOP_EVENT_EMITTER_PROVIDER } from '../NoopEventEmitterProvider'; -import { EventEmitter } from '../types/EventEmitter'; -import { EventEmitterOptions } from '../types/EventEmitterOptions'; +import { EventLoggerProvider } from '../types/EventLoggerProvider'; +import { NOOP_EVENT_LOGGER_PROVIDER } from '../NoopEventLoggerProvider'; +import { EventLogger } from '../types/EventLogger'; +import { EventLoggerOptions } from '../types/EventLoggerOptions'; export class EventsAPI { private static _instance?: EventsAPI; @@ -38,52 +38,48 @@ export class EventsAPI { return this._instance; } - public setGlobalEventEmitterProvider( - provider: EventEmitterProvider - ): EventEmitterProvider { + public setGlobalEventLoggerProvider( + provider: EventLoggerProvider + ): EventLoggerProvider { if (_global[GLOBAL_EVENTS_API_KEY]) { - return this.getEventEmitterProvider(); + return this.getEventLoggerProvider(); } - _global[GLOBAL_EVENTS_API_KEY] = makeGetter( + _global[GLOBAL_EVENTS_API_KEY] = makeGetter( API_BACKWARDS_COMPATIBILITY_VERSION, provider, - NOOP_EVENT_EMITTER_PROVIDER + NOOP_EVENT_LOGGER_PROVIDER ); return provider; } /** - * Returns the global event emitter provider. + * Returns the global event logger provider. * - * @returns EventEmitterProvider + * @returns EventLoggerProvider */ - public getEventEmitterProvider(): EventEmitterProvider { + public getEventLoggerProvider(): EventLoggerProvider { return ( _global[GLOBAL_EVENTS_API_KEY]?.(API_BACKWARDS_COMPATIBILITY_VERSION) ?? - NOOP_EVENT_EMITTER_PROVIDER + NOOP_EVENT_LOGGER_PROVIDER ); } /** - * Returns a event emitter from the global event emitter provider. + * Returns a event logger from the global event logger provider. * - * @returns EventEmitter + * @returns EventLogger */ - public getEventEmitter( + public getEventLogger( name: string, version?: string, - options?: EventEmitterOptions - ): EventEmitter { - return this.getEventEmitterProvider().getEventEmitter( - name, - version, - options - ); + options?: EventLoggerOptions + ): EventLogger { + return this.getEventLoggerProvider().getEventLogger(name, version, options); } - /** Remove the global event emitter provider */ + /** Remove the global event logger provider */ public disable(): void { delete _global[GLOBAL_EVENTS_API_KEY]; } diff --git a/experimental/packages/api-events/src/index.ts b/experimental/packages/api-events/src/index.ts index 63fadffd48..dbd464027e 100644 --- a/experimental/packages/api-events/src/index.ts +++ b/experimental/packages/api-events/src/index.ts @@ -14,10 +14,10 @@ * limitations under the License. */ -export * from './types/EventEmitter'; -export * from './types/EventEmitterProvider'; +export * from './types/EventLogger'; +export * from './types/EventLoggerProvider'; export * from './types/Event'; -export * from './types/EventEmitterOptions'; +export * from './types/EventLoggerOptions'; import { EventsAPI } from './api/events'; export const events = EventsAPI.getInstance(); diff --git a/experimental/packages/api-events/src/internal/global-utils.ts b/experimental/packages/api-events/src/internal/global-utils.ts index d58b890127..171cb0e1c7 100644 --- a/experimental/packages/api-events/src/internal/global-utils.ts +++ b/experimental/packages/api-events/src/internal/global-utils.ts @@ -14,7 +14,7 @@ * limitations under the License. */ -import { EventEmitterProvider } from '../types/EventEmitterProvider'; +import { EventLoggerProvider } from '../types/EventLoggerProvider'; import { _globalThis } from '../platform'; export const GLOBAL_EVENTS_API_KEY = Symbol.for( @@ -23,7 +23,7 @@ export const GLOBAL_EVENTS_API_KEY = Symbol.for( type Get = (version: number) => T; type OtelGlobal = Partial<{ - [GLOBAL_EVENTS_API_KEY]: Get; + [GLOBAL_EVENTS_API_KEY]: Get; }>; export const _global = _globalThis as OtelGlobal; diff --git a/experimental/packages/api-events/src/types/EventEmitter.ts b/experimental/packages/api-events/src/types/EventLogger.ts similarity index 96% rename from experimental/packages/api-events/src/types/EventEmitter.ts rename to experimental/packages/api-events/src/types/EventLogger.ts index 1222339516..9a465b9c48 100644 --- a/experimental/packages/api-events/src/types/EventEmitter.ts +++ b/experimental/packages/api-events/src/types/EventLogger.ts @@ -16,7 +16,7 @@ import { Event } from './Event'; -export interface EventEmitter { +export interface EventLogger { /** * Emit an event. This method should only be used by instrumentations emitting events. * diff --git a/experimental/packages/api-events/src/types/EventEmitterOptions.ts b/experimental/packages/api-events/src/types/EventLoggerOptions.ts similarity index 95% rename from experimental/packages/api-events/src/types/EventEmitterOptions.ts rename to experimental/packages/api-events/src/types/EventLoggerOptions.ts index f5b983884e..93aa29780a 100644 --- a/experimental/packages/api-events/src/types/EventEmitterOptions.ts +++ b/experimental/packages/api-events/src/types/EventLoggerOptions.ts @@ -16,7 +16,7 @@ import { Attributes } from '@opentelemetry/api'; -export interface EventEmitterOptions { +export interface EventLoggerOptions { /** * The schemaUrl of the tracer or instrumentation library * @default '' diff --git a/experimental/packages/api-events/src/types/EventEmitterProvider.ts b/experimental/packages/api-events/src/types/EventLoggerProvider.ts similarity index 51% rename from experimental/packages/api-events/src/types/EventEmitterProvider.ts rename to experimental/packages/api-events/src/types/EventLoggerProvider.ts index 26c45b8306..69eebe9202 100644 --- a/experimental/packages/api-events/src/types/EventEmitterProvider.ts +++ b/experimental/packages/api-events/src/types/EventLoggerProvider.ts @@ -14,25 +14,25 @@ * limitations under the License. */ -import { EventEmitter } from './EventEmitter'; -import { EventEmitterOptions } from './EventEmitterOptions'; +import { EventLogger } from './EventLogger'; +import { EventLoggerOptions } from './EventLoggerOptions'; /** - * A registry for creating named {@link EventEmitter}s. + * A registry for creating named {@link EventLogger}s. */ -export interface EventEmitterProvider { +export interface EventLoggerProvider { /** - * Returns an EventEmitter, creating one if one with the given name, version, and + * Returns an EventLogger, creating one if one with the given name, version, and * schemaUrl pair is not already created. * - * @param name The name of the event emitter or instrumentation library. - * @param version The version of the event emitter or instrumentation library. - * @param options The options of the event emitter or instrumentation library. - * @returns EventEmitter An event emitter with the given name and version. + * @param name The name of the event logger or instrumentation library. + * @param version The version of the event logger or instrumentation library. + * @param options The options of the event logger or instrumentation library. + * @returns EventLogger An event logger with the given name and version. */ - getEventEmitter( + getEventLogger( name: string, version?: string, - options?: EventEmitterOptions - ): EventEmitter; + options?: EventLoggerOptions + ): EventLogger; } diff --git a/experimental/packages/api-events/test/api/api.test.ts b/experimental/packages/api-events/test/api/api.test.ts index 27a4b23b5c..4fb0509397 100644 --- a/experimental/packages/api-events/test/api/api.test.ts +++ b/experimental/packages/api-events/test/api/api.test.ts @@ -15,57 +15,57 @@ */ import * as assert from 'assert'; -import { EventEmitter, events } from '../../src'; -import { NoopEventEmitter } from '../../src/NoopEventEmitter'; -import { NoopEventEmitterProvider } from '../../src/NoopEventEmitterProvider'; +import { EventLogger, events } from '../../src'; +import { NoopEventLogger } from '../../src/NoopEventLogger'; +import { NoopEventLoggerProvider } from '../../src/NoopEventLoggerProvider'; describe('API', () => { - const dummyEventEmitter = new NoopEventEmitter(); + const dummyEventLogger = new NoopEventLogger(); - it('should expose a event emitter provider via getEventEmitterProvider', () => { - const provider = events.getEventEmitterProvider(); + it('should expose a event logger provider via getEventLoggerProvider', () => { + const provider = events.getEventLoggerProvider(); assert.ok(provider); assert.strictEqual(typeof provider, 'object'); }); - describe('GlobalEventEmitterProvider', () => { + describe('GlobalEventLoggerProvider', () => { beforeEach(() => { events.disable(); }); - it('should use the global event emitter provider', () => { - events.setGlobalEventEmitterProvider(new TestEventEmitterProvider()); - const eventEmitter = events - .getEventEmitterProvider() - .getEventEmitter('name'); - assert.deepStrictEqual(eventEmitter, dummyEventEmitter); + it('should use the global event logger provider', () => { + events.setGlobalEventLoggerProvider(new TestEventLoggerProvider()); + const eventLogger = events + .getEventLoggerProvider() + .getEventLogger('name'); + assert.deepStrictEqual(eventLogger, dummyEventLogger); }); it('should not allow overriding global provider if already set', () => { - const provider1 = new TestEventEmitterProvider(); - const provider2 = new TestEventEmitterProvider(); - events.setGlobalEventEmitterProvider(provider1); - assert.equal(events.getEventEmitterProvider(), provider1); - events.setGlobalEventEmitterProvider(provider2); - assert.equal(events.getEventEmitterProvider(), provider1); + const provider1 = new TestEventLoggerProvider(); + const provider2 = new TestEventLoggerProvider(); + events.setGlobalEventLoggerProvider(provider1); + assert.equal(events.getEventLoggerProvider(), provider1); + events.setGlobalEventLoggerProvider(provider2); + assert.equal(events.getEventLoggerProvider(), provider1); }); }); - describe('getEventEmitter', () => { + describe('getEventLogger', () => { beforeEach(() => { events.disable(); }); - it('should return a event emitter instance from global provider', () => { - events.setGlobalEventEmitterProvider(new TestEventEmitterProvider()); - const eventEmitter = events.getEventEmitter('myEventEmitter'); - assert.deepStrictEqual(eventEmitter, dummyEventEmitter); + it('should return a event logger instance from global provider', () => { + events.setGlobalEventLoggerProvider(new TestEventLoggerProvider()); + const eventLogger = events.getEventLogger('myEventLogger'); + assert.deepStrictEqual(eventLogger, dummyEventLogger); }); }); - class TestEventEmitterProvider extends NoopEventEmitterProvider { - override getEventEmitter(): EventEmitter { - return dummyEventEmitter; + class TestEventLoggerProvider extends NoopEventLoggerProvider { + override getEventLogger(): EventLogger { + return dummyEventLogger; } } }); diff --git a/experimental/packages/api-events/test/internal/global.test.ts b/experimental/packages/api-events/test/internal/global.test.ts index 0a4eb04f57..cdf71b556c 100644 --- a/experimental/packages/api-events/test/internal/global.test.ts +++ b/experimental/packages/api-events/test/internal/global.test.ts @@ -19,7 +19,7 @@ import { _global, GLOBAL_EVENTS_API_KEY, } from '../../src/internal/global-utils'; -import { NoopEventEmitterProvider } from '../../src/NoopEventEmitterProvider'; +import { NoopEventLoggerProvider } from '../../src/NoopEventLoggerProvider'; const api1 = require('../../src') as typeof import('../../src'); @@ -34,8 +34,8 @@ describe('Global Utils', () => { assert.notStrictEqual(api1, api2); // that return separate noop instances to start assert.notStrictEqual( - api1.events.getEventEmitterProvider(), - api2.events.getEventEmitterProvider() + api1.events.getEventLoggerProvider(), + api2.events.getEventLoggerProvider() ); beforeEach(() => { @@ -43,38 +43,38 @@ describe('Global Utils', () => { api2.events.disable(); }); - it('should change the global event emitter provider', () => { - const original = api1.events.getEventEmitterProvider(); - const newEventEmitterProvider = new NoopEventEmitterProvider(); - api1.events.setGlobalEventEmitterProvider(newEventEmitterProvider); - assert.notStrictEqual(api1.events.getEventEmitterProvider(), original); + it('should change the global event logger provider', () => { + const original = api1.events.getEventLoggerProvider(); + const newEventLoggerProvider = new NoopEventLoggerProvider(); + api1.events.setGlobalEventLoggerProvider(newEventLoggerProvider); + assert.notStrictEqual(api1.events.getEventLoggerProvider(), original); assert.strictEqual( - api1.events.getEventEmitterProvider(), - newEventEmitterProvider + api1.events.getEventLoggerProvider(), + newEventLoggerProvider ); }); it('should load an instance from one which was set in the other', () => { - api1.events.setGlobalEventEmitterProvider(new NoopEventEmitterProvider()); + api1.events.setGlobalEventLoggerProvider(new NoopEventLoggerProvider()); assert.strictEqual( - api1.events.getEventEmitterProvider(), - api2.events.getEventEmitterProvider() + api1.events.getEventLoggerProvider(), + api2.events.getEventLoggerProvider() ); }); it('should disable both if one is disabled', () => { - const original = api1.events.getEventEmitterProvider(); + const original = api1.events.getEventLoggerProvider(); - api1.events.setGlobalEventEmitterProvider(new NoopEventEmitterProvider()); + api1.events.setGlobalEventLoggerProvider(new NoopEventLoggerProvider()); - assert.notStrictEqual(original, api1.events.getEventEmitterProvider()); + assert.notStrictEqual(original, api1.events.getEventLoggerProvider()); api2.events.disable(); - assert.strictEqual(original, api1.events.getEventEmitterProvider()); + assert.strictEqual(original, api1.events.getEventLoggerProvider()); }); it('should return the module NoOp implementation if the version is a mismatch', () => { - const original = api1.events.getEventEmitterProvider(); - api1.events.setGlobalEventEmitterProvider(new NoopEventEmitterProvider()); + const original = api1.events.getEventLoggerProvider(); + api1.events.setGlobalEventLoggerProvider(new NoopEventLoggerProvider()); const afterSet = _global[GLOBAL_EVENTS_API_KEY]!(-1); assert.strictEqual(original, afterSet); diff --git a/experimental/packages/api-events/test/noop-implementations/noop-event-emitter-provider.test.ts b/experimental/packages/api-events/test/noop-implementations/noop-event-logger-provider.test.ts similarity index 62% rename from experimental/packages/api-events/test/noop-implementations/noop-event-emitter-provider.test.ts rename to experimental/packages/api-events/test/noop-implementations/noop-event-logger-provider.test.ts index 346a339ce9..995eb473a3 100644 --- a/experimental/packages/api-events/test/noop-implementations/noop-event-emitter-provider.test.ts +++ b/experimental/packages/api-events/test/noop-implementations/noop-event-logger-provider.test.ts @@ -15,25 +15,25 @@ */ import * as assert from 'assert'; -import { NoopEventEmitter } from '../../src/NoopEventEmitter'; -import { NoopEventEmitterProvider } from '../../src/NoopEventEmitterProvider'; +import { NoopEventLogger } from '../../src/NoopEventLogger'; +import { NoopEventLoggerProvider } from '../../src/NoopEventLoggerProvider'; describe('NoopLoggerProvider', () => { it('should not crash', () => { - const eventEmitterProvider = new NoopEventEmitterProvider(); + const eventLoggerProvider = new NoopEventLoggerProvider(); assert.ok( - eventEmitterProvider.getEventEmitter('emitter-name') instanceof - NoopEventEmitter + eventLoggerProvider.getEventLogger('logger-name') instanceof + NoopEventLogger ); assert.ok( - eventEmitterProvider.getEventEmitter('emitter-name', 'v1') instanceof - NoopEventEmitter + eventLoggerProvider.getEventLogger('logger-name', 'v1') instanceof + NoopEventLogger ); assert.ok( - eventEmitterProvider.getEventEmitter('emitter-name', 'v1', { + eventLoggerProvider.getEventLogger('logger-name', 'v1', { schemaUrl: 'https://opentelemetry.io/schemas/1.7.0', - }) instanceof NoopEventEmitter + }) instanceof NoopEventLogger ); }); }); diff --git a/experimental/packages/api-events/test/noop-implementations/noop-event-emitter.test.ts b/experimental/packages/api-events/test/noop-implementations/noop-event-logger.test.ts similarity index 65% rename from experimental/packages/api-events/test/noop-implementations/noop-event-emitter.test.ts rename to experimental/packages/api-events/test/noop-implementations/noop-event-logger.test.ts index 1e4f0a4382..b29a6271bf 100644 --- a/experimental/packages/api-events/test/noop-implementations/noop-event-emitter.test.ts +++ b/experimental/packages/api-events/test/noop-implementations/noop-event-logger.test.ts @@ -15,18 +15,18 @@ */ import * as assert from 'assert'; -import { NoopEventEmitter } from '../../src/NoopEventEmitter'; -import { NoopEventEmitterProvider } from '../../src/NoopEventEmitterProvider'; +import { NoopEventLogger } from '../../src/NoopEventLogger'; +import { NoopEventLoggerProvider } from '../../src/NoopEventLoggerProvider'; -describe('NoopEventEmitter', () => { +describe('NoopEventLogger', () => { it('constructor should not crash', () => { - const logger = new NoopEventEmitterProvider().getEventEmitter('test-noop'); - assert(logger instanceof NoopEventEmitter); + const logger = new NoopEventLoggerProvider().getEventLogger('test-noop'); + assert(logger instanceof NoopEventLogger); }); it('calling emit should not crash', () => { - const emitter = new NoopEventEmitterProvider().getEventEmitter('test-noop'); - emitter.emit({ + const logger = new NoopEventLoggerProvider().getEventLogger('test-noop'); + logger.emit({ name: 'event name', }); });