Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Environments] ConsoleLogger does not handle all console environments #1847

Closed
MSNev opened this issue Jan 19, 2021 · 2 comments
Closed

[Environments] ConsoleLogger does not handle all console environments #1847

MSNev opened this issue Jan 19, 2021 · 2 comments
Assignees
@MSNev
Labels
bug Something isn't working

Comments

@MSNev
Copy link
Contributor

MSNev commented Jan 19, 2021

What version of OpenTelemetry are you using?

v 0.14

The current ConsoleLogger implementation does not support running in environments that
@MSNev MSNev added the bug Something isn't working label Jan 19, 2021
@MSNev MSNev mentioned this issue Jan 19, 2021
Closed
@MSNev
Copy link
Contributor Author

MSNev commented Jan 27, 2021

Please assign this to me as it will be fixed as part of the api.diag and new associated api.DiagConsoleLogger implementation

@MSNev MSNev mentioned this issue Jan 28, 2021
Merged
@MSNev MSNev mentioned this issue Feb 12, 2021
Merged
@MSNev
Copy link
Contributor Author

MSNev commented Feb 18, 2021

This is included in v0.17

@MSNev MSNev closed this as completed Feb 18, 2021
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@trentm @pichlermarc
test(instrumentation-aws-sdk): skip failing tests of @aws-sdk/client-…
196aa2d 
…sqs ReceiveMessage context handling (open-telemetry#1847)

In `@aws-sdk/client-sqs` v3.316 the SQS client methods became async. This breaks
the `utils.bindPromise` usage that attempts to propagate the SQS ReceiveMessage
span context to the user's handler for the method's returned promise.
Fixing that propagation is for open-telemetry#707 or another issue.

This change is a workaround that skips the testing of that span context
propagation feature.

Fixes: open-telemetry#1477
Refs: open-telemetry#707
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSNev MSNev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MSNev