Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-tracer: review if config can be optional when creating it #236

Closed
vmarchaud opened this issue Sep 5, 2019 · 1 comment

Comments

@vmarchaud
Copy link
Member

commented Sep 5, 2019

Currently all fields of the config are optional so we may allow later on for it to be optional too for the API to be simpler

@vmarchaud vmarchaud added the bug label Sep 5, 2019

@mayurkale22 mayurkale22 added Discussion enhancement and removed bug labels Sep 5, 2019

@mayurkale22 mayurkale22 added this to the SDK complete milestone Sep 5, 2019

@danielkhan danielkhan added this to To do in Code hygiene and infrastructure via automation Sep 19, 2019

@danielkhan danielkhan added this to To do in Node.js Tracer via automation Sep 19, 2019

@vmarchaud

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2019

I believe its good to close this one since #257 has landed

@vmarchaud vmarchaud closed this Sep 19, 2019

Node.js Tracer automation moved this from To do to Done Sep 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.