Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Is it applicable for Node or Browser or both
Do you expect this plugin to be commonly used
What version of plugin are you interested in using
Implementation of datadog: https://github.com/DataDog/dd-trace-js/tree/master/packages/datadog-plugin-express
You can get the route attribute.
I have already done an express plugin internally for OpenTelemetry and I don't see a real advantage to have it in this repo (I'm not against to have it too)... I did it because some packages like
I think the express plugin is more useful for customizing the span.
@OlivierAlbertini I didn't had the issue with my OC plugin, that's weird.
@dyladan That was a common request back when i worked at @keymetrics to allow customers to aggregate by the route (since it's common to have an id in urls). Also useful to pinpoint if you have a sync middleware (like auth with jwt) taking a lot of time.
I'm not sure to understand since it was dropping the scope it should fail to create child spans afterward, i don't see why it's a good win ^^
Currently we have Opencensus and OpenTelemetry in our environnement and we have the issue with OpenCensus "0.0.19" for sure and OpenTelemetry "0.1.1".
It doesn't happens every time (it's really hard to reproduce) and I don't know how the body parser works but having a middleware after have fixed the issue. I flagged those spans differently in order to see if there is a pattern...
@dyladan, yes I can work with @vmarchaud. I can make a draft PR and request a review (@vmarchaud ) but you can create a PR too since you made the issue and I can review it... As you want @vmarchaud, you decide ^^