Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic tracing of ws #667

Open
vmarchaud opened this issue Jan 5, 2020 · 6 comments
Open

automatic tracing of ws #667

vmarchaud opened this issue Jan 5, 2020 · 6 comments
Assignees
Projects
Milestone

Comments

@vmarchaud
Copy link
Member

@vmarchaud vmarchaud commented Jan 5, 2020

Is it applicable for Node or Browser or both
Node

Do you expect this plugin to be commonly used
Weekly Downloads: 10M (https://www.npmjs.com/package/ws)

What version of plugin are you interested in using
Versions: 5 - 7 (cover last 2 years of releases)

Additional context

  • Is there a reference you could point for the well-defined lifecycle methods

I believe only elastic implemented an intrumentation for this module (https://github.com/elastic/apm-agent-nodejs/blob/master/lib/instrumentation/modules/ws.js)

@vmarchaud vmarchaud added this to To do in Plugins via automation Jan 5, 2020
@dyladan dyladan added the up-for-grabs label Jan 5, 2020
@obecny

This comment has been minimized.

Copy link
Member

@obecny obecny commented Jan 7, 2020

Should we also support web socket on web too then ?

@dyladan

This comment has been minimized.

Copy link
Contributor

@dyladan dyladan commented Jan 7, 2020

Does websocket have a place to put the traceparent? afaik there is no way to add the tracing info without potentially modifying the user's payload?

@vmarchaud

This comment has been minimized.

Copy link
Member Author

@vmarchaud vmarchaud commented Jan 7, 2020

@obecny I believe we should at some point but i would prefer to open a dedicated issue

@dyladan The websocket handshake is done in http, so we could use that i believe. It depend if we want one trace per connection or one trace per packet

@dyladan

This comment has been minimized.

Copy link
Contributor

@dyladan dyladan commented Jan 8, 2020

One per connection is of dubious value... Most websocket use cases are long running and encompass many user actions.

@nstawski

This comment has been minimized.

Copy link
Contributor

@nstawski nstawski commented Jan 8, 2020

I would love to take this task. Would take me some time to solve though.

@vmarchaud

This comment has been minimized.

Copy link
Member Author

@vmarchaud vmarchaud commented Jan 9, 2020

@nstawski Feel free to ping me if you need any help or guidance on that, i've already looked up on how to implement that in the past.

@mayurkale22 mayurkale22 added this to the Alpha v0.4 milestone Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Plugins
  
To do
5 participants
You can’t perform that action at this time.