From 8c0679ec5a7ac2fb96990f9bee3fde2369681a52 Mon Sep 17 00:00:00 2001 From: Bartlomiej Obecny Date: Thu, 4 Jun 2020 22:56:37 +0200 Subject: [PATCH 1/2] chore: creating new metric kind --- packages/opentelemetry-metrics/src/export/types.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/opentelemetry-metrics/src/export/types.ts b/packages/opentelemetry-metrics/src/export/types.ts index 8a34a34d1b..e4910e49c3 100644 --- a/packages/opentelemetry-metrics/src/export/types.ts +++ b/packages/opentelemetry-metrics/src/export/types.ts @@ -21,8 +21,12 @@ import { Resource } from '@opentelemetry/resources'; /** The kind of metric. */ export enum MetricKind { COUNTER, + UP_DOWN_COUNTER, VALUE_RECORDER, - OBSERVER, + OBSERVER, // deprecated + SUM_OBSERVER, + UP_DOWN_SUM_OBSERVER, + VALUE_OBSERVER, } /** Sum returns an aggregated sum. */ From 1805ab3089728bcd3a452d6a81897d272dbd3648 Mon Sep 17 00:00:00 2001 From: Bartlomiej Obecny Date: Fri, 5 Jun 2020 20:57:14 +0200 Subject: [PATCH 2/2] chore: adding todo to remove observer kind later --- packages/opentelemetry-metrics/src/export/types.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/opentelemetry-metrics/src/export/types.ts b/packages/opentelemetry-metrics/src/export/types.ts index e4910e49c3..33dd539972 100644 --- a/packages/opentelemetry-metrics/src/export/types.ts +++ b/packages/opentelemetry-metrics/src/export/types.ts @@ -23,7 +23,7 @@ export enum MetricKind { COUNTER, UP_DOWN_COUNTER, VALUE_RECORDER, - OBSERVER, // deprecated + OBSERVER, // @TODO remove later #1146 SUM_OBSERVER, UP_DOWN_SUM_OBSERVER, VALUE_OBSERVER,