Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add start method on tracer and initialize PluginLoader #168

Open
wants to merge 1 commit into
base: master
from

Conversation

@mayurkale22
Copy link
Contributor

commented Aug 6, 2019

Closes #143

I will add more tests once initial approach looks ok.

@mayurkale22

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

@mayurkale22 mayurkale22 force-pushed the mayurkale22:tracer.start branch from a9cd1ae to 2ae0d61 Aug 6, 2019

@rochdev

rochdev approved these changes Aug 7, 2019

Copy link
Member

left a comment

Left a small nit about an unnecessary constructor but otherwise LGTM.

/**
* Constructs a new Tracer instance.
*/
constructor(config: BasicTracerConfig) {
super(
constructor() {

This comment has been minimized.

Copy link
@rochdev

rochdev Aug 7, 2019

Member

Removing the constructor will have the same effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.