Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace arguments per spread array to fix lint issue #182

Merged
merged 2 commits into from Aug 9, 2019

Conversation

@vmarchaud
Copy link
Member

commented Aug 8, 2019

@vmarchaud vmarchaud force-pushed the vmarchaud:ah-scope-lint branch from 091e187 to ccfff8b Aug 8, 2019

@danielkhan danielkhan requested a review from bg451 Aug 9, 2019

@rochdev

rochdev approved these changes Aug 9, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 9, 2019

Codecov Report

Merging #182 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   92.92%   92.92%           
=======================================
  Files          50       50           
  Lines        1499     1499           
  Branches       99       99           
=======================================
  Hits         1393     1393           
  Misses        106      106
Impacted Files Coverage Δ
...ry-scope-async-hooks/src/AsyncHooksScopeManager.ts 100% <100%> (ø) ⬆️

@mayurkale22 mayurkale22 merged commit f37e3a7 into open-telemetry:master Aug 9, 2019

7 checks passed

ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node11 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation mayurkale22 authorized
Details

@vmarchaud vmarchaud deleted the vmarchaud:ah-scope-lint branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.