Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename opentelemetry-basic-tracer -> opentelemetry-tracer-basic #380

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@mayurkale22
Copy link
Contributor

commented Sep 30, 2019

Which problem is this PR solving?

  • Originates from #334 (comment), please thumbs up or approve if you agree.

  • Assuming Tracer Web stick to opentelemetry-tracer-web.

@mayurkale22

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2019

/cc @obecny

@mayurkale22 mayurkale22 requested a review from markwolff Sep 30, 2019
@mayurkale22 mayurkale22 force-pushed the mayurkale22:tracer-basic branch from bf642de to c21f63f Oct 1, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Oct 1, 2019

Codecov Report

Merging #380 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   97.92%   97.94%   +0.01%     
==========================================
  Files         106      106              
  Lines        5110     5105       -5     
  Branches      427      431       +4     
==========================================
- Hits         5004     5000       -4     
+ Misses        106      105       -1
Impacted Files Coverage Δ
...pentelemetry-tracer-basic/test/BasicTracer.test.ts 100% <ø> (ø)
...ges/opentelemetry-exporter-jaeger/src/transform.ts 100% <ø> (ø) ⬆️
...-plugin-http/test/integrations/http-enable.test.ts 91.91% <ø> (ø) ⬆️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <ø> (ø) ⬆️
...etry-tracer-basic/src/export/BatchSpanProcessor.ts 100% <ø> (ø)
packages/opentelemetry-tracer-basic/src/utility.ts 100% <ø> (ø)
...try-tracer-basic/src/export/SimpleSpanProcessor.ts 100% <ø> (ø)
...entelemetry-tracer-basic/src/MultiSpanProcessor.ts 100% <ø> (ø)
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <ø> (ø) ⬆️
packages/opentelemetry-tracer-basic/src/config.ts 100% <ø> (ø)
... and 29 more
@mayurkale22 mayurkale22 merged commit 75a3297 into open-telemetry:master Oct 1, 2019
8 checks passed
8 checks passed
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node11 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation mayurkale22 authorized
Details
@mayurkale22 mayurkale22 deleted the mayurkale22:tracer-basic branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.