Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename BasicTracer to SDKTracer #389

Closed
wants to merge 1 commit into from

Conversation

@bg451
Copy link
Contributor

commented Oct 2, 2019

Which problem is this PR solving?

Short description of the changes

  • The idea here is to get rid of the basic term usage since this is the SDK implementation of the tracer at the end of the day. We can also add a lib for shared sdk types as types like resource and sampler get moved to the SDK level.

This change is Reviewable

@mayurkale22

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2019

/cc @draffensperger I think you joined SIG meeting after the discussion. What do you think about this?

@draffensperger

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

SGTM. I think the word "basic" sounds mildly negative, so calling it SDK is fine.

@danielkhan

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

Might collide with #408
Could everyone please check the newly proposed naming rules before we go ahead with this PR?

@mayurkale22

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

Can we close this one in favor of #413?

@bg451

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

Yep yep, basic tracer should still be renamed to SDK tracer imo but that's a new PR

@bg451 bg451 closed this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.