Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add plugin request issue template #407

Merged
merged 2 commits into from Oct 5, 2019

Conversation

@mayurkale22
Copy link
Contributor

commented Oct 4, 2019

Which problem is this PR solving?

@codecov-io

This comment has been minimized.

Copy link

commented Oct 4, 2019

Codecov Report

Merging #407 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
- Coverage   97.95%   97.89%   -0.06%     
==========================================
  Files         106      105       -1     
  Lines        5176     5142      -34     
  Branches      430      432       +2     
==========================================
- Hits         5070     5034      -36     
- Misses        106      108       +2
Impacted Files Coverage Δ
...-plugin-http/test/functionals/http-package.test.ts 93.93% <0%> (-4.55%) ⬇️
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts 100% <0%> (ø) ⬆️
...node-sdk/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-node-sdk/src/config.ts
...pentelemetry-node-sdk/src/instrumentation/utils.ts 100% <0%> (+4%) ⬆️
Copy link
Contributor

left a comment

One minor edit but other than that LGTM

.github/ISSUE_TEMPLATE/plugin_request.md Outdated Show resolved Hide resolved
Co-Authored-By: dyladan <dyladan@users.noreply.github.com>
@dyladan
dyladan approved these changes Oct 5, 2019
@danielkhan danielkhan merged commit 00cd2ec into open-telemetry:master Oct 5, 2019
7 of 8 checks passed
7 of 8 checks passed
ci/circleci: node12 Your tests failed on CircleCI
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node11 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation mayurkale22 authorized
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.