Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pg): add postgres plugin skeleton #411

Merged

Conversation

@markwolff
Copy link
Member

commented Oct 7, 2019

Which problem is this PR solving?

Short description of the changes

  • Adds skeleton for postgres plugin
@@ -0,0 +1,61 @@
{
"name": "@opentelemetry/plugin-postgres",

This comment has been minimized.

Copy link
@markwolff

markwolff Oct 7, 2019

Author Member

Unsure if this should be named plugin-postgres or plugin-pg. The actual npm package name is pg and not postgres, so naming it plugin-pg would be less confusing. Naming it plugin-postgres gives better visibility of what the plugin does.

This comment has been minimized.

Copy link
@mayurkale22

mayurkale22 Oct 7, 2019

Contributor

+1 for plugin-postgres.

This comment has been minimized.

Copy link
@OlivierAlbertini

OlivierAlbertini Oct 7, 2019

Member

+1 for plugin-postgres.

@mayurkale22

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

To unblock @markwolff, I'd like to merge this PR. We can rename package later, if required.

@mayurkale22 mayurkale22 merged commit 3b3030c into open-telemetry:master Oct 8, 2019
8 checks passed
8 checks passed
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node11 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation markwolff authorized
Details
@markwolff markwolff deleted the markwolff:markwolff/add-pg-plugin branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.