Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
chore: rename Metric Handle to Bound Instrument #638
Which problem is this PR solving?
Short description of the changes
Updated references of:
The spec appears to make a distinction between
But I couldn't find any delineation separating these 2 types in this repo. Hence the change of Handle to BoundInstrument and all other subtypes defined as instruments (Counter, Gauge, etc).
Further down it also present the concept of
So maybe the
Please let me know if I missed anything in the rename or renamed something that shouldn't have been.
@@ Coverage Diff @@ ## master #638 +/- ## ========================================= - Coverage 89.88% 89.68% -0.2% ========================================= Files 213 212 -1 Lines 10234 10065 -169 Branches 933 935 +2 ========================================= - Hits 9199 9027 -172 - Misses 1035 1038 +3
dyladan left a comment
I was going through and commenting on these and I noticed a trend where you renamed
Ok good this was my main question that you answered, because I didn't understand the difference between