Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-pg-pool): fix codecov path #657

Merged
merged 2 commits into from Jan 4, 2020

Conversation

@mayurkale22
Copy link
Member

mayurkale22 commented Jan 2, 2020

Which problem is this PR solving?

Currently, pg-pool plugin codecov report floating outside packages/ folder, see below image. Ideally, it should stay inside a packages/ folder similar to other modules.

Screen Shot 2020-01-02 at 12 24 59 PM

/cc @xiao-lix

@dyladan
dyladan approved these changes Jan 2, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 2, 2020

Codecov Report

Merging #657 into master will decrease coverage by 1.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
- Coverage   91.46%   89.62%   -1.85%     
==========================================
  Files         214      214              
  Lines       10043    10039       -4     
  Branches      913      931      +18     
==========================================
- Hits         9186     8997     -189     
- Misses        857     1042     +185
Impacted Files Coverage Δ
packages/opentelemetry-core/test/utils/url.test.ts 50% <0%> (-50%) ⬇️
...pentelemetry-core/test/internal/validators.test.ts 50% <0%> (-50%) ⬇️
...elemetry-core/test/trace/spancontext-utils.test.ts 55.55% <0%> (-44.45%) ⬇️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 56.52% <0%> (-43.48%) ⬇️
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 60% <0%> (-40%) ⬇️
...s/opentelemetry-core/test/context/B3Format.test.ts 63.39% <0%> (-36.61%) ⬇️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts 63.63% <0%> (-36.37%) ⬇️
...s/opentelemetry-core/test/trace/tracestate.test.ts 65.06% <0%> (-34.94%) ⬇️
...kages/opentelemetry-metrics/test/mocks/Exporter.ts 66.66% <0%> (-33.34%) ⬇️
...ntelemetry-core/test/trace/NoRecordingSpan.test.ts 71.42% <0%> (-28.58%) ⬇️
... and 61 more
@mayurkale22 mayurkale22 modified the milestones: Alpha v0.3.2, Alpha v0.3.3 Jan 3, 2020
@mayurkale22 mayurkale22 merged commit 7124f5f into open-telemetry:master Jan 4, 2020
6 checks passed
6 checks passed
ci/circleci: lint_&_docs Your tests passed on CircleCI!
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation mayurkale22 authorized
Details
@mayurkale22 mayurkale22 deleted the mayurkale22:plugin-pg-pool branch Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.