Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 0.3.2 (patch) release proposal #659

Merged
merged 3 commits into from Jan 3, 2020

Conversation

@mayurkale22
Copy link
Member

mayurkale22 commented Jan 2, 2020

Which problem is this PR solving?

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 2, 2020

Codecov Report

Merging #659 into master will decrease coverage by 3.29%.
The diff coverage is 12%.

@@           Coverage Diff            @@
##           master    #659     +/-   ##
========================================
- Coverage   94.79%   91.5%   -3.3%     
========================================
  Files         136     216     +80     
  Lines        7778   10132   +2354     
  Branches      666     916    +250     
========================================
+ Hits         7373    9271   +1898     
- Misses        405     861    +456
Impacted Files Coverage Δ
...ckages/opentelemetry-plugin-mongodb/src/version.ts 0% <0%> (ø)
...ges/opentelemetry-scope-async-hooks/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-plugin-https/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-plugin-dns/src/version.ts 0% <0%> (ø) ⬆️
...kages/opentelemetry-exporter-jaeger/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-plugin-http/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-plugin-redis/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-web/src/version.ts 0% <0%> (ø)
packages/opentelemetry-metrics/src/version.ts 0% <0%> (ø) ⬆️
... and 111 more
@mayurkale22 mayurkale22 added the Draft label Jan 3, 2020
@dyladan

This comment has been minimized.

Copy link
Contributor

dyladan commented Jan 3, 2020

It looks like some of the version.ts files weren't generated. Can you run lerna run compile again to make sure they are all up to date?

@mayurkale22 mayurkale22 marked this pull request as ready for review Jan 3, 2020
@mayurkale22

This comment has been minimized.

Copy link
Member Author

mayurkale22 commented Jan 3, 2020

It looks like some of the version.ts files weren't generated. Can you run lerna run compile again to make sure they are all up to date?

I did that before, looks like all versions.ts files are available with correct version. Can you pls check again if I am missing anything else.

Copy link
Member

obecny left a comment

we have 14 examples, 30 packages, getting-started/traced-example - 1, main package.json - 1
14 + 30*2 + 1 + 1 = 76 files to be changed, I see 73 files changed, what is missing then

@obecny

This comment has been minimized.

Copy link
Member

obecny commented Jan 3, 2020

sry I checked that on different branch, 29 packages so 74 files should be changed

@mayurkale22

This comment has been minimized.

Copy link
Member Author

mayurkale22 commented Jan 3, 2020

sry I checked that on different branch, 29 packages so 74 files should be changed

getting-started/* is missing.

@obecny
obecny approved these changes Jan 3, 2020
@dyladan
dyladan approved these changes Jan 3, 2020
@mayurkale22 mayurkale22 force-pushed the mayurkale22:0.3.2-proposal branch from 8a38649 to 71da245 Jan 3, 2020
@vmarchaud

This comment has been minimized.

Copy link
Member

vmarchaud commented Jan 3, 2020

For #636, its already 9pm for me so i will not have the time to address comments on my PR today. I think that's fine to skip it for this release.

EDIT: Alternatively, if someone want to move it forward by pushing to my branch that's fine for me too, any contributors should have the permission to do so.

@mayurkale22

This comment has been minimized.

Copy link
Member Author

mayurkale22 commented Jan 3, 2020

For #636, its already 9pm for me so i will not have the time to address comments on my PR today. I think that's fine to skip it for this release.

SGTM, I moved it to Alpha v0.3.3 milestone.

@mayurkale22 mayurkale22 force-pushed the mayurkale22:0.3.2-proposal branch from 71da245 to f691343 Jan 3, 2020
@mayurkale22 mayurkale22 merged commit 3669648 into open-telemetry:master Jan 3, 2020
5 of 6 checks passed
5 of 6 checks passed
ci/circleci: lint_&_docs Your tests failed on CircleCI
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation mayurkale22 authorized
Details
@mayurkale22 mayurkale22 deleted the mayurkale22:0.3.2-proposal branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.