Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add test to ensure plugins support latest module versions #670

Open
wants to merge 1 commit into
base: master
from

Conversation

@dyladan
Copy link
Contributor

dyladan commented Jan 6, 2020

Which problem is this PR solving?

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #670 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
- Coverage   91.47%   91.41%   -0.06%     
==========================================
  Files         216      215       -1     
  Lines       10048    10010      -38     
  Branches      913      910       -3     
==========================================
- Hits         9191     9151      -40     
- Misses        857      859       +2
Impacted Files Coverage Δ
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
...es/opentelemetry-node/src/instrumentation/utils.ts 90.47% <0%> (-9.53%) ⬇️
packages/opentelemetry-plugin-mysql/src/utils.ts 90.9% <0%> (-4.55%) ⬇️
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
...telemetry-plugin-grpc/test/utils/assertionUtils.ts 100% <0%> (ø) ⬆️
.../opentelemetry-plugin-dns/test/utils/assertSpan.ts 100% <0%> (ø) ⬆️
...-metrics/test/export/ConsoleMetricExporter.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-zipkin/test/zipkin.test.ts 100% <0%> (ø) ⬆️
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts 100% <0%> (ø) ⬆️
...try-plugin-dns/test/functionals/dns-enable.test.ts 100% <0%> (ø) ⬆️
... and 7 more
Copy link
Member

vmarchaud left a comment

LGTM, but is there a way to get alerted on that ? Something directly on gitter or an issue on github would be easier no ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.