Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update date for v0.4 #677

Merged
merged 4 commits into from Jan 13, 2020
Merged

Conversation

@mayurkale22
Copy link
Member

mayurkale22 commented Jan 8, 2020

Which problem is this PR solving?

  • Per SIG discussion, updating release date for v0.4.
mayurkale22 added 2 commits Jan 8, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 8, 2020

Codecov Report

Merging #677 into master will increase coverage by 1.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   89.78%   91.55%   +1.76%     
==========================================
  Files         213      216       +3     
  Lines       10105    10146      +41     
  Branches      932      917      -15     
==========================================
+ Hits         9073     9289     +216     
+ Misses       1032      857     -175
Impacted Files Coverage Δ
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
...opentelemetry-core/src/trace/globaltracer-utils.ts 88.88% <0%> (-2.78%) ⬇️
...telemetry-core/src/context/propagation/B3Format.ts 94.59% <0%> (-1.41%) ⬇️
...core/src/context/propagation/BinaryTraceContext.ts 96.22% <0%> (-0.5%) ⬇️
packages/opentelemetry-plugin-dns/src/version.ts 100% <0%> (ø) ⬆️
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-plugin-redis/src/version.ts 100% <0%> (ø) ⬆️
...core/src/context/propagation/NoopHttpTextFormat.ts 100% <0%> (ø) ⬆️
...telemetry-plugin-grpc/test/utils/assertionUtils.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-core/src/version.ts 100% <0%> (ø) ⬆️
... and 35 more
@dyladan

This comment has been minimized.

Copy link
Contributor

dyladan commented Jan 13, 2020

I approved this, but I don't think we will have these things by the end of January...

@mayurkale22

This comment has been minimized.

Copy link
Member Author

mayurkale22 commented Jan 13, 2020

I approved this, but I don't think we will have these things by the end of January...

Totally agree, but this is better than the out-of-date (passed) and some known date to target for.

mayurkale22 added 2 commits Jan 13, 2020
@mayurkale22 mayurkale22 merged commit ebe0b1d into open-telemetry:master Jan 13, 2020
5 of 6 checks passed
5 of 6 checks passed
ci/circleci: lint_&_docs Your tests failed on CircleCI
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation mayurkale22 authorized
Details
@mayurkale22 mayurkale22 deleted the mayurkale22:v4_date branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.