Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix build errors #747

Merged
merged 2 commits into from Feb 5, 2020
Merged

Conversation

@dyladan
Copy link
Contributor

dyladan commented Jan 29, 2020

Fixes an issue that prevented lerna from being used on node 8.

  • Switch from yarn to npm. This will install lerna even on node 8. note: technically we are installing a devDependency that is incompatible with node 8 (lerna), but it is ok because we don't use the feature which uses the broken module.
  • Skip checking the broken link so build will pass.

todo: create a follow up PR that removes the skip of the broken link after it is published to npm #751

@OlivierAlbertini

This comment has been minimized.

Copy link
Member

OlivierAlbertini commented Jan 29, 2020

I'm reviewing this and on my branch I did exactly the same thing (without changing tdd script) and I get the same issue...

@dyladan

This comment has been minimized.

Copy link
Contributor Author

dyladan commented Jan 29, 2020

looking into it

@dyladan dyladan force-pushed the dynatrace-oss-contrib:use-npm branch 2 times, most recently from ccfa941 to 7760b3a Feb 3, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 3, 2020

Codecov Report

Merging #747 into master will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #747      +/-   ##
=========================================
+ Coverage   96.22%   96.5%   +0.27%     
=========================================
  Files         208      67     -141     
  Lines        9488    1603    -7885     
  Branches      809     131     -678     
=========================================
- Hits         9130    1547    -7583     
+ Misses        358      56     -302
Impacted Files Coverage Δ
...ges/opentelemetry-propagator-jaeger/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-api/src/api/metrics.ts 53.33% <0%> (ø) ⬆️
packages/opentelemetry-core/src/common/time.ts 95.38% <0%> (ø) ⬆️
...opentelemetry-core/src/platform/node/timer-util.ts 50% <0%> (ø) ⬆️
...y-api/test/noop-implementations/noop-meter.test.ts 97.22% <0%> (ø) ⬆️
...elemetry-api/src/distributed_context/EntryValue.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-core/src/version.ts 100% <0%> (ø) ⬆️
...ackages/opentelemetry-core/src/platform/node/id.ts 100% <0%> (ø) ⬆️
...core/src/context/propagation/BinaryTraceContext.ts 96.22% <0%> (ø) ⬆️
...try-propagator-jaeger/src/JaegerHttpTraceFormat.ts 95.65% <0%> (ø) ⬆️
... and 197 more
@dyladan dyladan force-pushed the dynatrace-oss-contrib:use-npm branch from c0e861c to 539026e Feb 4, 2020
@dyladan dyladan changed the title chore: switch from yarn to npm chore: fix build errors Feb 4, 2020
@dyladan

This comment has been minimized.

Copy link
Contributor Author

dyladan commented Feb 4, 2020

@open-telemetry/javascript-approvers I know this has had a lot of updates but I just squashed it all down into two commits. Please take a look and review.

Copy link
Member

mayurkale22 left a comment

Nice work, thanks for fixing the build.

@mayurkale22 mayurkale22 merged commit 5c9ad85 into open-telemetry:master Feb 5, 2020
6 checks passed
6 checks passed
ci/circleci: lint_&_docs Your tests passed on CircleCI!
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation dyladan authorized
Details
@dyladan dyladan mentioned this pull request Feb 5, 2020
@dyladan dyladan deleted the dynatrace-oss-contrib:use-npm branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.