Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update examples and getting started for provider and api package #750

Conversation

@dyladan
Copy link
Contributor

dyladan commented Jan 29, 2020

  • Finishes the provider rename in examples and getting started
  • Updates examples and getting started for api package update
@dyladan dyladan changed the title chore: rename provider in examples and getting started update examples and getting started for provider and api package Jan 29, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #750 into master will increase coverage by 4.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   90.88%   95.87%   +4.98%     
==========================================
  Files         233      160      -73     
  Lines       10438     6260    -4178     
  Branches      965      498     -467     
==========================================
- Hits         9487     6002    -3485     
+ Misses        951      258     -693
Impacted Files Coverage Δ
...in-postgres/opentelemetry-plugin-pg/src/version.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-core/src/common/types.ts 100% <0%> (ø) ⬆️
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
.../opentelemetry-core/src/trace/spancontext-utils.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-core/src/utils/url.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-plugin-redis/src/version.ts 100% <0%> (ø) ⬆️
...pentelemetry-core/src/platform/node/performance.ts 100% <0%> (ø) ⬆️
...ckages/opentelemetry-plugin-ioredis/src/version.ts 100% <0%> (ø) ⬆️
...metry-core/src/trace/instrumentation/BasePlugin.ts 81.57% <0%> (-5.27%) ⬇️
...-plugin-postgres/opentelemetry-plugin-pg/src/pg.ts 91.52% <0%> (ø) ⬆️
... and 187 more
…mples
@dyladan

This comment has been minimized.

Copy link
Contributor Author

dyladan commented Feb 4, 2020

@open-telemetry/javascript-approvers please review this. Until it is merged examples, getting started, and benchmark are all failing on master.

Copy link
Member

mayurkale22 left a comment

Added a few comments, looks like we are still using core instead of api module esp. init provider and get tracer.

examples/ioredis/tracer.js Outdated Show resolved Hide resolved
getting-started/ts-example/README.md Outdated Show resolved Hide resolved
examples/basic-tracer-node/index.js Outdated Show resolved Hide resolved
examples/basic-tracer-node/index.js Outdated Show resolved Hide resolved
Copy link
Member

mayurkale22 left a comment

lgtm

dyladan added 2 commits Feb 5, 2020
@mayurkale22 mayurkale22 merged commit c5bc438 into open-telemetry:master Feb 5, 2020
6 checks passed
6 checks passed
ci/circleci: lint_&_docs Your tests passed on CircleCI!
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation dyladan authorized
Details
@Flarna Flarna deleted the dynatrace-oss-contrib:rename-provider-examples branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.