Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 0.4.0 release proposal #751

Merged
merged 2 commits into from Feb 5, 2020
Merged

Conversation

@mayurkale22
Copy link
Member

mayurkale22 commented Jan 29, 2020

Which problem is this PR solving?

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #751 into master will increase coverage by 3.83%.
The diff coverage is 20%.

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
+ Coverage   89.49%   93.33%   +3.83%     
==========================================
  Files         153       32     -121     
  Lines        5188      675    -4513     
  Branches      442       54     -388     
==========================================
- Hits         4643      630    -4013     
+ Misses        545       45     -500
Impacted Files Coverage Δ
packages/opentelemetry-api/src/version.ts 0% <0%> (ø) ⬆️
...ges/opentelemetry-propagator-jaeger/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-scope-base/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-base/src/version.ts 0% <0%> (ø) ⬆️
...ckages/opentelemetry-plugin-mongodb/src/version.ts 100% <100%> (ø)
...y-api/test/noop-implementations/noop-meter.test.ts 97.22% <0%> (ø) ⬆️
...-api/src/context/propagation/NoopHttpTextFormat.ts 100% <0%> (ø) ⬆️
...opentelemetry-base/test/resources/resource.test.ts 100% <0%> (ø) ⬆️
...telemetry-scope-base/test/NoopScopeManager.test.ts 100% <0%> (ø) ⬆️
...opentelemetry-api/src/metrics/NoopMeterProvider.ts 100% <0%> (ø) ⬆️
... and 126 more
@dyladan

This comment has been minimized.

Copy link
Contributor

dyladan commented Jan 29, 2020

Did you intentionally not update examples/getting started?

@mayurkale22

This comment has been minimized.

Copy link
Member Author

mayurkale22 commented Jan 29, 2020

Did you intentionally not update examples/getting started?

Yes, we can update that after the release.

@dyladan

This comment has been minimized.

Copy link
Contributor

dyladan commented Jan 29, 2020

holding the approval until #749 is merged and included in this but overall LGTM

@OlivierAlbertini

This comment has been minimized.

Copy link
Member

OlivierAlbertini commented Jan 30, 2020

to merge after #747

@OlivierAlbertini

This comment has been minimized.

Copy link
Member

OlivierAlbertini commented Jan 30, 2020

Should we wait for

?

#628 would also add breaking changes.

@mayurkale22

This comment has been minimized.

Copy link
Member Author

mayurkale22 commented Jan 30, 2020

Yes, I am waiting for #749. I am not sure about the current state of #628 /cc @dyladan

@dyladan

This comment has been minimized.

Copy link
Contributor

dyladan commented Jan 30, 2020

Yes wait for #749

#628 should probably be closed. there is some talk in specs about making configuration mechanisms standardized across SIGs.

@mayurkale22 mayurkale22 force-pushed the mayurkale22:draft_0.4.0 branch from cef3a40 to f648b3a Feb 3, 2020
@mayurkale22

This comment has been minimized.

Copy link
Member Author

mayurkale22 commented Feb 4, 2020

holding the approval until #749 is merged and included in this but overall LGTM

@dyladan #749 merged into master, please review this PR.

@mayurkale22 mayurkale22 force-pushed the mayurkale22:draft_0.4.0 branch from f648b3a to a212076 Feb 4, 2020
@dyladan
dyladan approved these changes Feb 4, 2020
@obecny

This comment has been minimized.

Copy link
Member

obecny commented Feb 4, 2020

this should not be released - all examples doesn't work because of api changes

@mayurkale22

This comment has been minimized.

Copy link
Member Author

mayurkale22 commented Feb 4, 2020

this should not be released - all examples doesn't work because of api changes

Waiting on #750

@dyladan dyladan mentioned this pull request Feb 4, 2020
@mayurkale22 mayurkale22 force-pushed the mayurkale22:draft_0.4.0 branch 2 times, most recently from 8ea7a74 to 053aa73 Feb 5, 2020
@dyladan

This comment has been minimized.

Copy link
Contributor

dyladan commented Feb 5, 2020

Think this is good to go 🚀

@obecny

This comment has been minimized.

Copy link
Member

obecny commented Feb 5, 2020

#761 yet before that

@mayurkale22 mayurkale22 force-pushed the mayurkale22:draft_0.4.0 branch from 053aa73 to 708056a Feb 5, 2020
@obecny

This comment has been minimized.

Copy link
Member

obecny commented Feb 5, 2020

Few questions with regards to

  1. examples
  2. getting started (versioning and still using registry instead of provider).
  3. might be not related to this but do we already have "MeterProvider" instead of "MeterRegistry" ?
@mayurkale22

This comment has been minimized.

Copy link
Member Author

mayurkale22 commented Feb 5, 2020

Few questions with regards to ...

I think we have updated all the places (examples, getting-started etc.) to use latest code changes as per the master branch. I will update the examples version after the release.

@mayurkale22 mayurkale22 self-assigned this Feb 5, 2020
@mayurkale22 mayurkale22 force-pushed the mayurkale22:draft_0.4.0 branch from 708056a to 3054b43 Feb 5, 2020
@mayurkale22 mayurkale22 merged commit 0d52bf5 into open-telemetry:master Feb 5, 2020
6 checks passed
6 checks passed
ci/circleci: lint_&_docs Your tests passed on CircleCI!
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation mayurkale22 authorized
Details
@mayurkale22 mayurkale22 deleted the mayurkale22:draft_0.4.0 branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.