Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DistributedContext to CorrelationContext #834

Merged
merged 2 commits into from Mar 4, 2020

Conversation

@mayurkale22
Copy link
Member

mayurkale22 commented Mar 3, 2020

Which problem is this PR solving?

@dyladan
dyladan approved these changes Mar 4, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 4, 2020

Codecov Report

Merging #834 into master will decrease coverage by 1.81%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #834      +/-   ##
==========================================
- Coverage   94.36%   92.55%   -1.82%     
==========================================
  Files         248      244       -4     
  Lines       10723    10772      +49     
  Branches     1027     1046      +19     
==========================================
- Hits        10119     9970     -149     
- Misses        604      802     +198
Impacted Files Coverage Δ
packages/opentelemetry-api/src/metrics/Metric.ts 100% <ø> (ø) ⬆️
...kages/opentelemetry-metrics/src/BoundInstrument.ts 100% <ø> (ø) ⬆️
...elemetry-api/src/correlation_context/EntryValue.ts 100% <ø> (ø)
...ackages/opentelemetry-api/src/metrics/NoopMeter.ts 72.09% <0%> (ø) ⬆️
...ry-api/test/noop-implementations/noop-span.test.ts 45.83% <0%> (-54.17%) ⬇️
...-api/test/noop-implementations/noop-tracer.test.ts 47.82% <0%> (-52.18%) ⬇️
...s/opentelemetry-core/test/context/B3Format.test.ts 50% <0%> (-50%) ⬇️
packages/opentelemetry-core/test/utils/url.test.ts 50% <0%> (-50%) ⬇️
...pentelemetry-core/test/internal/validators.test.ts 50% <0%> (-50%) ⬇️
...elemetry-core/test/trace/spancontext-utils.test.ts 55.55% <0%> (-44.45%) ⬇️
... and 51 more
@dyladan dyladan mentioned this pull request Mar 4, 2020
44 of 46 tasks complete
@mayurkale22 mayurkale22 merged commit fd9c7ab into open-telemetry:master Mar 4, 2020
7 checks passed
7 checks passed
ci/circleci: lint_&_docs Your tests passed on CircleCI!
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node13 Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation mayurkale22 authorized
Details
@mayurkale22 mayurkale22 deleted the mayurkale22:CorrelationContext branch Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.