Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update examples to use register #848

Merged

Conversation

@dyladan
Copy link
Contributor

dyladan commented Mar 11, 2020

Which problem is this PR solving?

  • Use simplified API registration in all examples
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 11, 2020

Codecov Report

Merging #848 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
+ Coverage   92.63%   92.71%   +0.08%     
==========================================
  Files         252      254       +2     
  Lines       11113    11277     +164     
  Branches     1069     1082      +13     
==========================================
+ Hits        10295    10456     +161     
- Misses        818      821       +3
Impacted Files Coverage Δ
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
...ages/opentelemetry-plugin-http/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
...ges/opentelemetry-tracing/src/NoopSpanProcessor.ts 50% <0%> (-10%) ⬇️
...es/opentelemetry-node/src/instrumentation/utils.ts 90.47% <0%> (-9.53%) ⬇️
...kages/opentelemetry-node/test/registration.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-plugin-dns/src/version.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-resources/src/constants.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/config.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/utility.ts 100% <0%> (ø) ⬆️
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c842117...05ea188. Read the comment docs.

@@ -25,7 +25,7 @@ module.exports = (serviceName) => {
provider.addSpanProcessor(new SimpleSpanProcessor(exporter));

// Initialize the OpenTelemetry APIs to use the BasicTracerProvider bindings
opentelemetry.trace.setGlobalTracerProvider(provider);
provider.register();

This comment has been minimized.

Copy link
@OlivierAlbertini

OlivierAlbertini Mar 11, 2020

Member

Should we add it as well to the example in the README ?

This comment has been minimized.

Copy link
@mayurkale22

mayurkale22 Mar 11, 2020

Member

+1, also getting-started guide?

examples/basic-tracer-node/index.js Show resolved Hide resolved
examples/grpc/tracer.js Outdated Show resolved Hide resolved
dyladan added 3 commits Mar 11, 2020
…opentelemetry-js into register-examples
Copy link
Member

mayurkale22 left a comment

Please fix the build, otherwise LGTM

getting-started/README.md Outdated Show resolved Hide resolved
dyladan added 2 commits Mar 11, 2020
@dyladan dyladan merged commit 02c1d66 into open-telemetry:master Mar 12, 2020
7 checks passed
7 checks passed
ci/circleci: lint_&_docs Your tests passed on CircleCI!
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node13 Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation dyladan authorized
Details
@dyladan dyladan deleted the dynatrace-oss-contrib:register-examples branch Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.