From 2ac1d32147872464c783022612a45de1e346be46 Mon Sep 17 00:00:00 2001 From: Olivier Albertini Date: Fri, 13 Mar 2020 11:12:08 -0400 Subject: [PATCH 1/2] fix: change loglevel for beta closes #578 Signed-off-by: Olivier Albertini --- packages/opentelemetry-core/src/common/ConsoleLogger.ts | 2 +- packages/opentelemetry-metrics/src/types.ts | 2 +- packages/opentelemetry-tracing/src/config.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/opentelemetry-core/src/common/ConsoleLogger.ts b/packages/opentelemetry-core/src/common/ConsoleLogger.ts index 3028b9d2b0..561fa74d95 100644 --- a/packages/opentelemetry-core/src/common/ConsoleLogger.ts +++ b/packages/opentelemetry-core/src/common/ConsoleLogger.ts @@ -18,7 +18,7 @@ import { Logger } from '@opentelemetry/api'; import { LogLevel } from './types'; export class ConsoleLogger implements Logger { - constructor(level: LogLevel = LogLevel.DEBUG) { + constructor(level: LogLevel = LogLevel.INFO) { if (level >= LogLevel.DEBUG) { this.debug = (...args) => { console.debug(...args); diff --git a/packages/opentelemetry-metrics/src/types.ts b/packages/opentelemetry-metrics/src/types.ts index c444668ce3..0c578844b8 100644 --- a/packages/opentelemetry-metrics/src/types.ts +++ b/packages/opentelemetry-metrics/src/types.ts @@ -72,7 +72,7 @@ export interface MeterConfig { /** Default Meter configuration. */ export const DEFAULT_CONFIG = { - logLevel: LogLevel.DEBUG, + logLevel: LogLevel.INFO, }; /** The default metric creation options value. */ diff --git a/packages/opentelemetry-tracing/src/config.ts b/packages/opentelemetry-tracing/src/config.ts index 157d767683..99eb0d22fd 100644 --- a/packages/opentelemetry-tracing/src/config.ts +++ b/packages/opentelemetry-tracing/src/config.ts @@ -31,7 +31,7 @@ export const DEFAULT_MAX_LINKS_PER_SPAN = 32; */ export const DEFAULT_CONFIG = { defaultAttributes: {}, - logLevel: LogLevel.DEBUG, + logLevel: LogLevel.INFO, sampler: ALWAYS_SAMPLER, traceParams: { numberOfAttributesPerSpan: DEFAULT_MAX_ATTRIBUTES_PER_SPAN, From a39b66c1a7d85735363161d6a2558ca75360cde7 Mon Sep 17 00:00:00 2001 From: Olivier Albertini Date: Fri, 13 Mar 2020 11:38:08 -0400 Subject: [PATCH 2/2] test: update to new default LogLevel Signed-off-by: Olivier Albertini --- packages/opentelemetry-core/test/common/ConsoleLogger.test.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/opentelemetry-core/test/common/ConsoleLogger.test.ts b/packages/opentelemetry-core/test/common/ConsoleLogger.test.ts index d8e4765748..f35dfe38e4 100644 --- a/packages/opentelemetry-core/test/common/ConsoleLogger.test.ts +++ b/packages/opentelemetry-core/test/common/ConsoleLogger.test.ts @@ -65,8 +65,6 @@ describe('ConsoleLogger', () => { assert.deepStrictEqual(warnCalledArgs, ['warn called %s', 'param1']); consoleLogger.info('info called %s', 'param1'); assert.deepStrictEqual(infoCalledArgs, ['info called %s', 'param1']); - consoleLogger.debug('debug called %s', 'param1'); - assert.deepStrictEqual(debugCalledArgs, ['debug called %s', 'param1']); }); it('should log with debug', () => {