Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark Propagators and release 0.5.0 numbers #870

Merged
merged 3 commits into from Mar 18, 2020

Conversation

@mayurkale22
Copy link
Member

mayurkale22 commented Mar 17, 2020

Which problem is this PR solving?

  • Fix benchmark suite

  • Update new release numbers

Beginning B3Propagator Benchmark...
2 tests completed.
#Inject x 2,018,725 ops/sec ±3.49% (100 runs sampled)

This comment has been minimized.

Copy link
@mayurkale22

mayurkale22 Mar 17, 2020

Author Member

Both the propagators throughput (ops/sec) has dropped significantly since 0.3.3 version.

This comment has been minimized.

Copy link
@dyladan

dyladan Mar 17, 2020

Contributor

I believe this is most likely due to the getter/setter being functions instead of property accesses now. Because we are still able to process multiple millions of operations per second, I believe this is unlikely to be an issue or bottleneck in any real world js applications.

mayurkale22 added 2 commits Mar 17, 2020
@mayurkale22 mayurkale22 merged commit 53d41d3 into open-telemetry:master Mar 18, 2020
7 checks passed
7 checks passed
ci/circleci: lint_&_docs Your tests passed on CircleCI!
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node13 Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation mayurkale22 authorized
Details
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 18, 2020

Codecov Report

Merging #870 into master will decrease coverage by 3.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
- Coverage   92.50%   88.94%   -3.57%     
==========================================
  Files         246      102     -144     
  Lines       10943     2668    -8275     
  Branches     1065      330     -735     
==========================================
- Hits        10123     2373    -7750     
+ Misses        820      295     -525     
Impacted Files Coverage Δ
...ckages/opentelemetry-core/src/common/NoopLogger.ts 80.00% <0.00%> (-3.34%) ⬇️
packages/opentelemetry-core/src/version.ts 100.00% <0.00%> (ø)
packages/opentelemetry-core/src/utils/url.ts 100.00% <0.00%> (ø)
...ages/opentelemetry-core/src/internal/validators.ts 100.00% <0.00%> (ø)
...es/opentelemetry-exporter-collector/test/helper.ts 100.00% <0.00%> (ø)
.../opentelemetry-core/src/trace/spancontext-utils.ts 100.00% <0.00%> (ø)
...opentelemetry-api/src/metrics/NoopMeterProvider.ts 100.00% <0.00%> (ø)
...pentelemetry-core/src/platform/node/performance.ts 100.00% <0.00%> (ø)
...telemetry-core/test/platform/hex-to-base64.test.ts 100.00% <0.00%> (ø)
...metry-context-base/test/NoopContextManager.test.ts 100.00% <0.00%> (ø)
... and 170 more
@mayurkale22 mayurkale22 deleted the mayurkale22:benchmark_0.5.0 branch Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.