Notify users when webhooks are disabled #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
added
the
Skip Changelog
matej-g
reviewed
Mar 10, 2023
main.go
Outdated
| @@ -241,6 +241,8 @@ func main() { | |||
| instrumentation.NewMutator(logger, mgr.GetClient()), | |||
| }), | |||
| }) | |||
| } else { | |||
| ctrl.Log.Info("Webhooks are disabled, operator is running in not-supported mode", "ENABLE_WEBHOOKS", "false") | |||
There was a problem hiding this comment.
Should this be be warning rather than info? And one small suggestion:
Suggested change
| ctrl.Log.Info("Webhooks are disabled, operator is running in not-supported mode", "ENABLE_WEBHOOKS", "false") | |
| ctrl.Log.Info("Webhooks are disabled, operator is running in an unsupported mode", "ENABLE_WEBHOOKS", "false") |
There was a problem hiding this comment.
changed the message.
I am not sure how to produce a message on warn level. There is this just an API to get a logger at specific verbosity level. I didn't manage to get warn logs with it.
logger.V(N).Info("test")
jaronoff97
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1569