New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OTLP/HTTP Default Port Per Changes to the Spec #438
Update OTLP/HTTP Default Port Per Changes to the Spec #438
Conversation
Codecov Report
@@ Coverage Diff @@
## main #438 +/- ##
=========================================
Coverage 91.14% 91.14%
Complexity 804 804
=========================================
Files 76 76
Lines 1977 1977
=========================================
Hits 1802 1802
Misses 175 175
Continue to review full report at Codecov.
|
Not sure I quite understand why the first codecov/project check failed, but may be missing something subtle |
For the 2nd commit,
As for the docker-compose update, looks good to me. |
Saw (late) this was already being taken care of in #440 so I removed the commit I had for it from this PR |
c288b7f
to
3cbeef9
Compare
My apologies @Grunet - I thought you had force pushed Sean’s changes, but they had not quite made it into |
@bobstrecansky I saw Sean's changes were merged into main so I brought all of main's changes into my branch now (was having trouble rebasing so merged instead) |
Resolves #431
My biggest concern has to do with the 2nd commit, in particular b/c I couldn't find evidence in the spec of a non-protobuf-ed HTTP transport mechanism, which it seemed like Contrib/Otlp/Exporter.php is trying to do (sending an ordinary HTTP request, maybe with a JSON body). So I wasn't sure if updating the default port was appropriate in this case.
A smaller concern also has to do with the 2nd commit, namely if updating the port on the collector container in the compose file was OK (seemed to me like it was per this PR from the collector repo)