diff --git a/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/__init__.py b/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/__init__.py index d31b1ffec3..af82ae2be7 100644 --- a/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/__init__.py +++ b/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/__init__.py @@ -191,8 +191,7 @@ def _which_channel(self, kwargs): if "channel_type" in kwargs: if kwargs.get("channel_type") == "secure": return ("secure_channel",) - else: - return ("insecure_channel",) + return ("insecure_channel",) # handle modern arguments types = [] diff --git a/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_client.py b/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_client.py index 5da7c55534..3cf4c74df7 100644 --- a/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_client.py +++ b/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_client.py @@ -184,14 +184,14 @@ def intercept_unary(self, request, metadata, client_info, invoker): try: result = invoker(request, metadata) - except grpc.RpcError as e: + except grpc.RpcError as err: guarded_span.generated_span.set_status( Status(StatusCode.ERROR) ) guarded_span.generated_span.set_attribute( - "rpc.grpc.status_code", e.code().value[0] + "rpc.grpc.status_code", err.code().value[0] ) - raise e + raise err return self._trace_result( guarded_span, rpc_info, result, client_info @@ -242,12 +242,12 @@ def _intercept_server_stream( response.ByteSize(), client_info.full_method ) yield response - except grpc.RpcError as e: + except grpc.RpcError as err: span.set_status(Status(StatusCode.ERROR)) span.set_attribute( - "rpc.grpc.status_code", e.code().value[0] + "rpc.grpc.status_code", err.code().value[0] ) - raise e + raise err def intercept_stream( self, request_or_iterator, metadata, client_info, invoker @@ -283,14 +283,14 @@ def intercept_stream( try: result = invoker(request_or_iterator, metadata) - except grpc.RpcError as e: + except grpc.RpcError as err: guarded_span.generated_span.set_status( Status(StatusCode.ERROR) ) guarded_span.generated_span.set_attribute( - "rpc.grpc.status_code", e.code().value[0], + "rpc.grpc.status_code", err.code().value[0], ) - raise e + raise err return self._trace_result( guarded_span, rpc_info, result, client_info