Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpanKind option at span creation (closes #103). #139

Merged
merged 4 commits into from Sep 18, 2019

Conversation

@Oberon00
Copy link
Member

commented Sep 16, 2019

Even though the Spec PR isn't merged and there's some discussion going on, I think this will be more useful than not being able to distinguish HTTP client & server at all.

@Oberon00 Oberon00 force-pushed the dynatrace-oss-contrib:spankind branch from 3362c0a to 9e0b8b3 Sep 16, 2019
Co-Authored-By: Aliaksei Urbanski <mimworkmail@gmail.com>
Co-authored-by: Mauricio Vásquez <mauriciovasquezbernal@gmail.com>
@@ -241,6 +241,7 @@ def __init__(
attributes: types.Attributes = None, # TODO
events: typing.Sequence[trace_api.Event] = None, # TODO
links: typing.Sequence[trace_api.Link] = None, # TODO
kind: trace_api.SpanKind = trace_api.SpanKind.INTERNAL,

This comment has been minimized.

Copy link
@lzchen

lzchen Sep 17, 2019

Collaborator

Add kind in the docstring

@lzchen
lzchen approved these changes Sep 17, 2019
@c24t
c24t approved these changes Sep 17, 2019
Copy link
Contributor

left a comment

LGTM

@reyang
reyang approved these changes Sep 18, 2019
Copy link
Contributor

left a comment

LGTM.

@reyang reyang merged commit dbb3be8 into open-telemetry:master Sep 18, 2019
2 checks passed
2 checks passed
cla/linuxfoundation Oberon00 authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.