Rails Data Export

[leoluchini]

Hi everyone,

I'm currently working on implementing opentelemetry-instrumentation-rails ~> 0.30, and while it is functional, I would like to modify the way the data is exported.

Currently, when I check the dashboard with the data, it is grouped by controller name and action, as shown in the attached screenshot:

This is the trace

My current configuration is

OpenTelemetry::SDK.configure do |c|
  c.service_name = ENV.fetch('OTEL_SERVICE_NAME')
  c.use_all( {'OpenTelemetry::Instrumentation::Rack' => { url_quantization: lambda { |path, _env|  path.to_s } }})
end

Instead of displaying the controller name and action, I would prefer to have the HTTP action and the path, such as GET /ping. Is this customization possible? Any assistance would be greatly appreciated.

Feel free to let me know if you have any specific preferences or if there are additional details you'd like to include in the message.

[arielvalentin]

Thanks again for reporting this issue.

I see here that the span name is being rewritten and I see why this is causing trouble for you, especially since it is not well documented.

Here is where the span name is being overridden and ignoring quantized span names:

opentelemetry-ruby-contrib/instrumentation/action_pack/lib/opentelemetry/instrumentation/action_pack/handlers/action_controller.rb

Line 29 in f5f21c6

rack_span.name = "#{payload[:controller]}##{payload[:action]}" unless request.env['action_dispatch.exception']

This is not compliant with the specification either so I think this needs to change but I think I need to discuss this with other maintainers today at the SIG and see what we think is the best direction to go here. When I have those details I will update this issue.

You will have to manually overwrite the span name in custom code as part of ActionController Base for now until we address this issue.

[github-actions]

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.