From f1e3fd50d01226e114862ed4df50b02d4ad372f7 Mon Sep 17 00:00:00 2001
From: Elias Rodrigues <elias19r@users.noreply.github.com>
Date: Mon, 15 May 2023 16:21:43 -0300
Subject: [PATCH] fix: Warning messages from gem build (#1439)

* fix: Warning messages from gem build

When running `gem build opentelemetry-metrics-api.gemspec` locally
I was getting the following warning messages:

    WARNING:  description and summary are identical
    WARNING:  open-ended dependency on bundler (>= 1.17, development) is not recommended
      if bundler is semantically versioned, use:
        add_development_dependency 'bundler', '~> 1.17'
    WARNING:  open-ended dependency on opentelemetry-test-helpers (>= 0, development)
      is not recommended
      use a bounded requirement, such as '~> x.y'
    WARNING:  See https://guides.rubygems.org/specification-reference/ for help
      Successfully built RubyGem
      Name: opentelemetry-metrics-api
      Version: 0.0.1
      File: opentelemetry-metrics-api-0.0.1.gem

This commit intends to fix them.

* Restore >= instead of ~> for bundler

* Disable Gemspec/DevelopmentDependencies in semantic_conventions

* Sort .rubocop.yml

---------

Co-authored-by: Robert <robertlaurin@users.noreply.github.com>
---
 metrics_api/opentelemetry-metrics-api.gemspec |  3 +-
 semantic_conventions/.rubocop.yml             | 36 +++++++++++--------
 2 files changed, 23 insertions(+), 16 deletions(-)

diff --git a/metrics_api/opentelemetry-metrics-api.gemspec b/metrics_api/opentelemetry-metrics-api.gemspec
index 9f7bb6c54c..867dd3982d 100644
--- a/metrics_api/opentelemetry-metrics-api.gemspec
+++ b/metrics_api/opentelemetry-metrics-api.gemspec
@@ -15,7 +15,6 @@ Gem::Specification.new do |spec|
   spec.email       = ['cncf-opentelemetry-contributors@lists.cncf.io']
 
   spec.summary     = 'A stats collection and distributed tracing framework'
-  spec.description = 'A stats collection and distributed tracing framework'
   spec.homepage    = 'https://github.com/open-telemetry/opentelemetry-ruby'
   spec.license     = 'Apache-2.0'
 
@@ -31,7 +30,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '>= 1.17'
   spec.add_development_dependency 'faraday', '~> 0.13'
   spec.add_development_dependency 'minitest', '~> 5.0'
-  spec.add_development_dependency 'opentelemetry-test-helpers'
+  spec.add_development_dependency 'opentelemetry-test-helpers', '~> 0.3.0'
   spec.add_development_dependency 'rake', '~> 12.0'
   spec.add_development_dependency 'rubocop', '~> 0.73.0'
   spec.add_development_dependency 'simplecov', '~> 0.17'
diff --git a/semantic_conventions/.rubocop.yml b/semantic_conventions/.rubocop.yml
index 4be1b17ab1..2f8fc17087 100644
--- a/semantic_conventions/.rubocop.yml
+++ b/semantic_conventions/.rubocop.yml
@@ -5,11 +5,27 @@ AllCops:
 Bundler/OrderedGems:
   Exclude:
     - gemfiles/**/*
+
+Gemspec/DevelopmentDependencies:
+  Enabled: false
+Gemspec/RequireMFA:
+  Enabled: false
+
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: false
+Layout/LineLength:
+  Enabled: false
+Layout/TrailingEmptyLines:
+  Enabled: false
+Layout/TrailingWhitespace:
+  Enabled: false
+
 Lint/UnusedMethodArgument:
   Enabled: false
+
 Metrics/AbcSize:
   Enabled: false
-Layout/LineLength:
+Metrics/BlockLength:
   Enabled: false
 Metrics/MethodLength:
   Max: 20
@@ -17,6 +33,11 @@ Metrics/ModuleLength:
   Enabled: false
 Metrics/ParameterLists:
   Enabled: false
+
+Naming/FileName:
+  Exclude:
+    - lib/opentelemetry-semantic_conventions.rb
+
 Style/FrozenStringLiteralComment:
   Exclude:
     - gemfiles/**/*
@@ -25,16 +46,3 @@ Style/ModuleFunction:
 Style/StringLiterals:
   Exclude:
     - gemfiles/**/*
-Metrics/BlockLength:
-  Enabled: false
-Naming/FileName:
-  Exclude:
-    - "lib/opentelemetry-semantic_conventions.rb"
-Layout/EmptyLinesAroundModuleBody:
-  Enabled: false
-Layout/TrailingWhitespace:
-  Enabled: false
-Layout/TrailingEmptyLines:
-  Enabled: false
-Gemspec/RequireMFA:
-  Enabled: false