Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry::SDK::Resources::Constants appears to be undocumented #379

Closed
genebean opened this issue Sep 12, 2020 · 6 comments · Fixed by #417
Closed

OpenTelemetry::SDK::Resources::Constants appears to be undocumented #379

genebean opened this issue Sep 12, 2020 · 6 comments · Fixed by #417
Assignees
Milestone

Comments

@genebean
Copy link
Contributor

When setting up the new Jaeger::CollectorExporter I came across OpenTelemetry::SDK::Resources::Constants::SERVICE_RESOURCE[:name] in its readme. I have not found any docs on this other than in its source code.

A readme in sdk/lib/opentelemetry/sdk/resources might be a good way to fix this.

@fbogsany
Copy link
Contributor

TBH, this is a terrible way to access this constant - for this one specifically, I think a helper in the configurator is justified:

c.service_name = 'my-service'

@genebean
Copy link
Contributor Author

There are a few in there that helpers might be nice for. The main one besides name is the one for an app’s version.

@fbogsany fbogsany added this to the Beta v0.7 milestone Sep 18, 2020
robertlaurin added a commit to robertlaurin/opentelemetry-ruby that referenced this issue Sep 22, 2020
Adds a convenience method so setter the service.name resource attribute.
Closes open-telemetry#379
fbogsany pushed a commit that referenced this issue Sep 22, 2020
Adds a convenience method so setter the service.name resource attribute.
Closes #379
@genebean
Copy link
Contributor Author

I think this should be reopened as there are still a lot of constants that need to be documented.

@robertlaurin
Copy link
Contributor

robertlaurin commented Sep 22, 2020

I may have eagerly closed this out, the constants are documented here https://github.com/open-telemetry/opentelemetry-specification/tree/master/specification/resource/semantic_conventions

Do you think that additional documentation should live within this repo? @genebean

@genebean
Copy link
Contributor Author

I do. Even if it is just a readme that points to the spec. There is no way the average user would know to go hunt that down in it's current home.

@fbogsany fbogsany reopened this Sep 23, 2020
@fbogsany fbogsany modified the milestones: Beta v0.8, Beta v0.9 Oct 27, 2020
@fbogsany fbogsany removed this from the Beta v0.9 milestone Jan 11, 2021
@fbogsany fbogsany added this to the Tracing v1.0 milestone Feb 18, 2021
@fbogsany
Copy link
Contributor

Closing this for now. The spec now requires a semantic-conventions package to be autogenerated from the semantic conventions YAML files in the spec. We've implemented this and removed the constants from the SDK gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants