From ce2c94119a378bc7d07276c3e05be0232bf277ad Mon Sep 17 00:00:00 2001 From: Francis Bogsanyi Date: Wed, 7 Aug 2019 15:36:05 -0400 Subject: [PATCH] Remove SpanData --- api/lib/opentelemetry/trace.rb | 1 - api/lib/opentelemetry/trace/span_data.rb | 49 ------------------------ api/lib/opentelemetry/trace/tracer.rb | 4 -- 3 files changed, 54 deletions(-) delete mode 100644 api/lib/opentelemetry/trace/span_data.rb diff --git a/api/lib/opentelemetry/trace.rb b/api/lib/opentelemetry/trace.rb index 6b2a056b15..306bbb1e11 100644 --- a/api/lib/opentelemetry/trace.rb +++ b/api/lib/opentelemetry/trace.rb @@ -5,7 +5,6 @@ # SPDX-License-Identifier: Apache-2.0 require 'opentelemetry/trace/span_context' -require 'opentelemetry/trace/span_data' require 'opentelemetry/trace/span_kind' require 'opentelemetry/trace/span' require 'opentelemetry/trace/tracer' diff --git a/api/lib/opentelemetry/trace/span_data.rb b/api/lib/opentelemetry/trace/span_data.rb deleted file mode 100644 index c9290f3e28..0000000000 --- a/api/lib/opentelemetry/trace/span_data.rb +++ /dev/null @@ -1,49 +0,0 @@ -# frozen_string_literal: true - -# Copyright 2019 OpenTelemetry Authors -# -# SPDX-License-Identifier: Apache-2.0 - -module OpenTelemetry - module Trace - # SpanData is an immutable object that is used to report out-of-band completed spans. - # - # TODO: consider whether to copy collections to a known internal form and expose only enumerations. - class SpanData - attr_reader :name, :kind, :start_timestamp, :end_timestamp, :context, :parent_span_id, :resource, :attributes, :timed_events, :links, :status - - def initialize( - name:, - kind:, - start_timestamp:, - end_timestamp:, - context:, - parent_span_id:, - resource:, - attributes:, - timed_events:, - links:, - status: - ) - @name = frozen(name) - @kind = kind || SpanKind::INTERNAL - @start_timestamp = start_timestamp - @end_timestamp = end_timestamp - @context = context - @parent_span_id = parent_span_id - @resource = frozen(resource) - @attributes = frozen(attributes) - @timed_events = frozen(timed_events) - @links = frozen(links) - @status = frozen(status) - end - - private - - # TODO: don't clone if already frozen, deep-freeze - def frozen(obj) - obj.clone.freeze - end - end - end -end diff --git a/api/lib/opentelemetry/trace/tracer.rb b/api/lib/opentelemetry/trace/tracer.rb index 8c9995460f..a393db0596 100644 --- a/api/lib/opentelemetry/trace/tracer.rb +++ b/api/lib/opentelemetry/trace/tracer.rb @@ -57,10 +57,6 @@ def start_span(name, with_parent: nil, with_parent_context: nil, sampler: nil, l end end - def record_span_data(span_data) - raise ArgumentError if span_data.nil? - end - def binary_format BINARY_FORMAT end