diff --git a/opentelemetry-sdk/CHANGELOG.md b/opentelemetry-sdk/CHANGELOG.md index 803dd0e32b..2838a84874 100644 --- a/opentelemetry-sdk/CHANGELOG.md +++ b/opentelemetry-sdk/CHANGELOG.md @@ -2,12 +2,37 @@ ## vNext -- Calls to `MeterProviderBuilder::with_resource`, `TracerProviderBuilder::with_resource`, +- Calls to `MeterProviderBuilder::with_resource`, `TracerProviderBuilder::with_resource`, `LoggerProviderBuilder::with_resource` are now additive ([#2677](https://github.com/open-telemetry/opentelemetry-rust/pull/2677)). -- *Breaking*: Make `force_flush()` in `PushMetricExporter` synchronous - Moved `ExportError` trait from `opentelemetry::trace::ExportError` to `opentelemetry_sdk::export::ExportError` - Moved `TraceError` enum from `opentelemetry::trace::TraceError` to `opentelemetry_sdk::trace::TraceError` - Moved `TraceResult` type alias from `opentelemetry::trace::TraceResult` to `opentelemetry_sdk::trace::TraceResult` +- *Breaking*: Make `force_flush()` in `PushMetricExporter` synchronous +- **Breaking Change:** Updated the `SpanExporter` trait method signature: + +```rust + fn export(&mut self, batch: Vec) -> BoxFuture<'static, OTelSdkResult>; +``` + + to + +```rust + fn export( + &mut self, + batch: Vec, +) -> impl std::future::Future + Send; +``` + + This affects anyone who writes custom exporters, as custom implementations of SpanExporter + should now define export as an `async fn`: + +```rust + impl trace::SpanExporter for CustomExporter { + async fn export(&mut self, batch: Vec) -> OTelSdkResult { + // Implementation here + } +} +``` ## 0.28.0 diff --git a/opentelemetry/CHANGELOG.md b/opentelemetry/CHANGELOG.md index 1c2d6e34b7..91b3089982 100644 --- a/opentelemetry/CHANGELOG.md +++ b/opentelemetry/CHANGELOG.md @@ -2,29 +2,10 @@ ## vNext -- **Breaking Change:** Updated the `SpanExporter` trait method signature: - ```rust - fn export(&mut self, batch: Vec) -> BoxFuture<'static, OTelSdkResult>; -``` - to -```rust - fn export( - &mut self, - batch: Vec, -) -> impl std::future::Future + Send; -``` - This affects the exporter devs, as custom implementations of SpanExporter - should now define export as an `async fn`: -```rust - impl trace::SpanExporter for CustomExporter { - async fn export(&mut self, batch: Vec) -> OTelSdkResult { - // Implementation here - } -} -``` - *Breaking* Moved `ExportError` trait from `opentelemetry::trace::ExportError` to `opentelemetry_sdk::export::ExportError` - *Breaking* Moved `TraceError` enum from `opentelemetry::trace::TraceError` to `opentelemetry_sdk::trace::TraceError` - *Breaking* Moved `TraceResult` type alias from `opentelemetry::trace::TraceResult` to `opentelemetry_sdk::trace::TraceResult` +- {PLACEHOLDER} - Remove the above completely. // TODO fill this when changes are actually in. ## 0.28.0