Skip to content

Conversation

@cijothomas
Copy link
Member

This log was pure noise, especially for Delta, as this will be emitted each cycle (if facing overflow). Spec does not suggest to do this logging either.
When overflow occurs, it is reflected in the attribute anyway, so no need of emitting another signal to indicate this situation has occurred.

@cijothomas cijothomas requested a review from a team as a code owner April 6, 2025 02:12
@codecov
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.3%. Comparing base (2564a71) to head (57ad8cb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2904     +/-   ##
=======================================
- Coverage   81.3%   81.3%   -0.1%     
=======================================
  Files        125     125             
  Lines      24132   24130      -2     
=======================================
- Hits       19628   19626      -2     
  Misses      4504    4504             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas merged commit 4b56ee3 into open-telemetry:main Apr 6, 2025
24 checks passed
@cijothomas cijothomas deleted the cijothomas/remove-excess-log branch April 6, 2025 14:38
cijothomas added a commit to cijothomas/opentelemetry-rust that referenced this pull request Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants