From 39b03ed7c90dce9d314bebf53b1dff67478535e8 Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Tue, 5 Jan 2021 14:33:06 +0900 Subject: [PATCH 1/6] Rename OTEL_EXPORTER to OTEL_EXPORTERS --- exporters | 0 spec-compliance-matrix.md | 2 +- specification/sdk-environment-variables.md | 4 ++-- 3 files changed, 3 insertions(+), 3 deletions(-) create mode 100644 exporters diff --git a/exporters b/exporters new file mode 100644 index 00000000000..e69de29bb2d diff --git a/spec-compliance-matrix.md b/spec-compliance-matrix.md index 40192aafe15..2ec0e1ba3a3 100644 --- a/spec-compliance-matrix.md +++ b/spec-compliance-matrix.md @@ -126,7 +126,7 @@ status of the feature is not known. |OTEL_EXPORTER_OTLP_* | | + | | + | + | - | - | | - | - | - | |OTEL_EXPORTER_JAEGER_* | | + | | + | + | - | - | + | - | - | - | |OTEL_EXPORTER_ZIPKIN_* | | + | | + | | - | - | | - | - | - | -|OTEL_EXPORTER | | - | | + | | | | | | - | - | +|OTEL_EXPORTERS | | - | | - | | | | | | - | - | |OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT | | + | | + | + | | | | | - | - | |OTEL_SPAN_EVENT_COUNT_LIMIT | | + | | + | + | | | | | - | - | |OTEL_SPAN_LINK_COUNT_LIMIT | | + | | + | + | | | | | - | - | diff --git a/specification/sdk-environment-variables.md b/specification/sdk-environment-variables.md index e4b7b9b4aae..e81686afbc6 100644 --- a/specification/sdk-environment-variables.md +++ b/specification/sdk-environment-variables.md @@ -77,9 +77,9 @@ See [OpenTelemetry Protocol Exporter Configuration Options](./protocol/exporter. | Name | Description | Default | | ------------- | ---------------------------------------------------------------------------- | ------- | -| OTEL_EXPORTER | Exporter to be used, can be a comma-separated list to use multiple exporters | "otlp" | +| OTEL_EXPORTERS | Exporters to be used as a comma separated list | "otlp" | -Known values for OTEL_EXPORTER are: "otlp", "jaeger", "zipkin", "prometheus", "otlp_span", "otlp_metric". +Known values for OTEL_EXPORTERS are: "otlp", "jaeger", "zipkin", "prometheus", "otlp_span", "otlp_metric". Note: "otlp" is equivalent to "otlp_span,otlp_metric". From d4502d6ced5d5d4c329dbe192b675c5995ecdee9 Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Wed, 6 Jan 2021 12:41:47 +0900 Subject: [PATCH 2/6] Split exporter variables --- specification/sdk-environment-variables.md | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/specification/sdk-environment-variables.md b/specification/sdk-environment-variables.md index e81686afbc6..5c47d7d4b63 100644 --- a/specification/sdk-environment-variables.md +++ b/specification/sdk-environment-variables.md @@ -75,13 +75,24 @@ See [OpenTelemetry Protocol Exporter Configuration Options](./protocol/exporter. ## Exporter Selection +We define environment variables for setting a single exporter per signal. SDKs SHOULD provide a means to +set multiple exporters for a signal programmatically. + | Name | Description | Default | | ------------- | ---------------------------------------------------------------------------- | ------- | -| OTEL_EXPORTERS | Exporters to be used as a comma separated list | "otlp" | +| OTEL_TRACE_EXPORTER | Trace exporter to be used | "otlp" | +| OTEL_METRICS_EXPORTER | Metrics exporter to be used | "otlp" | + +Known values for OTEL_TRACE_EXPORTER are: + +- `"otlp"`: [OTLP](./protocol/otlp.md) +- `"jaeger"`: [Jaeger gRPC](https://www.jaegertracing.io/docs/1.21/apis/#protobuf-via-grpc-stable) +- `"zipkin"`: [Zipkin](https://zipkin.io/zipkin-api/) (Defaults to [protobuf](https://github.com/openzipkin/zipkin-api/blob/master/zipkin.proto) format) -Known values for OTEL_EXPORTERS are: "otlp", "jaeger", "zipkin", "prometheus", "otlp_span", "otlp_metric". +Known values for OTEL_METRICS_EXPORTER are: -Note: "otlp" is equivalent to "otlp_span,otlp_metric". +- `"otlp"`: [OTLP](./protocol/otlp.md) +- `"prometheus"`: [Prometheus](https://github.com/prometheus/docs/blob/master/content/docs/instrumenting/exposition_formats.md) ## Language Specific Environment Variables From 07faed8aa77cd65f853420ce910b770ce75cb0e0 Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Wed, 6 Jan 2021 12:44:56 +0900 Subject: [PATCH 3/6] Update compliance matrix --- spec-compliance-matrix.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spec-compliance-matrix.md b/spec-compliance-matrix.md index 2ec0e1ba3a3..574a5ab98f6 100644 --- a/spec-compliance-matrix.md +++ b/spec-compliance-matrix.md @@ -126,7 +126,8 @@ status of the feature is not known. |OTEL_EXPORTER_OTLP_* | | + | | + | + | - | - | | - | - | - | |OTEL_EXPORTER_JAEGER_* | | + | | + | + | - | - | + | - | - | - | |OTEL_EXPORTER_ZIPKIN_* | | + | | + | | - | - | | - | - | - | -|OTEL_EXPORTERS | | - | | - | | | | | | - | - | +|OTEL_TRACE_EXPORTER | | - | | - | | | | | | - | - | +|OTEL_METRICS_EXPORTERS | | - | | - | | | | | | - | - | |OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT | | + | | + | + | | | | | - | - | |OTEL_SPAN_EVENT_COUNT_LIMIT | | + | | + | + | | | | | - | - | |OTEL_SPAN_LINK_COUNT_LIMIT | | + | | + | + | | | | | - | - | From cf3b6bffb08637974c7e509f3ae4bbf609b2bf38 Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Fri, 8 Jan 2021 11:55:08 +0900 Subject: [PATCH 4/6] Clean --- specification/sdk-environment-variables.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/specification/sdk-environment-variables.md b/specification/sdk-environment-variables.md index 5c47d7d4b63..46e9dbdb4b1 100644 --- a/specification/sdk-environment-variables.md +++ b/specification/sdk-environment-variables.md @@ -75,8 +75,7 @@ See [OpenTelemetry Protocol Exporter Configuration Options](./protocol/exporter. ## Exporter Selection -We define environment variables for setting a single exporter per signal. SDKs SHOULD provide a means to -set multiple exporters for a signal programmatically. +We define environment variables for setting a single exporter per signal. | Name | Description | Default | | ------------- | ---------------------------------------------------------------------------- | ------- | From fe8215f4d1c581b74a6e975296d21f980b55870b Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Sat, 9 Jan 2021 14:43:34 +0900 Subject: [PATCH 5/6] Changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e4fdf500c9a..4e0227def69 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,9 @@ Updates: - Additional Cassandra semantic attributes ([#1217](https://github.com/open-telemetry/opentelemetry-specification/pull/1217)) +- OTEL_EXPORTER environment variable replaced with OTEL_TRACE_EXPORTER and + OTEL_METRICS_EXPORTER which each accept only a single value, not a list. + ([#1318](https://github.com/open-telemetry/opentelemetry-specification/pull/1318)) - `process.runtime.description` resource convention: Add `java.vm.name` ([#1242](https://github.com/open-telemetry/opentelemetry-specification/pull/1242)) - Refine span name guideline for SQL database spans From df105be35ef42ca3a0be8d2bc2094840d9db5ecc Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Wed, 13 Jan 2021 00:06:10 +0900 Subject: [PATCH 6/6] Update spec-compliance-matrix.md Co-authored-by: Francis Bogsanyi --- spec-compliance-matrix.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec-compliance-matrix.md b/spec-compliance-matrix.md index c6a6d656f4a..04ab5726873 100644 --- a/spec-compliance-matrix.md +++ b/spec-compliance-matrix.md @@ -127,7 +127,7 @@ status of the feature is not known. |OTEL_EXPORTER_JAEGER_* | | + | | + | + | - | - | + | - | - | - | |OTEL_EXPORTER_ZIPKIN_* | | + | | + | | - | - | | - | - | - | |OTEL_TRACE_EXPORTER | | - | | - | | | | | | - | - | -|OTEL_METRICS_EXPORTERS | | - | | - | | | | | | - | - | +|OTEL_METRICS_EXPORTER | | - | | - | | | | | | - | - | |OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT | | + | | + | + | | | | | - | - | |OTEL_SPAN_EVENT_COUNT_LIMIT | | + | | + | + | | | | | - | - | |OTEL_SPAN_LINK_COUNT_LIMIT | | + | | + | + | | | | | - | - |