Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTelemetry API package layout #86

Merged
merged 4 commits into from Jun 10, 2019

Conversation

├── trace
│ ├── propagation # headers that are the public API for trace propagation, using different encodings.
│ └── samplers # is used to make decisions on `Span` sampling.
├── distributedcontext

This comment has been minimized.

Copy link
@reyang

reyang Jun 8, 2019

Does distributedcontext intend to cover local context (in-process propagation) as well?
If yes, suggest to consider context.

This comment has been minimized.

Copy link
@SergeyKanzhelev

SergeyKanzhelev Jun 8, 2019

Contributor

looks like a hot topic for the Tuesday specification group call =)

This comment has been minimized.

Copy link
@bogdandrutu

bogdandrutu Jun 10, 2019

Member

Based on the current Java reference implementation context (in-process) is a separate package, probably we should keep it that way as we discussed (currently we document the way java reference implementation did then later change if we agree otherwise).

This comment has been minimized.

Copy link
@SergeyKanzhelev

SergeyKanzhelev Jun 10, 2019

Contributor

missed this. @mayurkale22 can you please fix?

This comment has been minimized.

Copy link
@mayurkale22

mayurkale22 Jun 10, 2019

Author Contributor

Done

Show resolved Hide resolved specification/package-layout.md Outdated
@@ -0,0 +1,56 @@
# OpenTelemetry Project Package Layout

This comment has been minimized.

Copy link
@SergeyKanzhelev

SergeyKanzhelev Jun 8, 2019

Contributor

@mayurkale22 great document!

### `/internal` (_Optional_)
Private application and library code.

### `/log` (_In the future_)

This comment has been minimized.

Copy link
@SergeyKanzhelev

SergeyKanzhelev Jun 8, 2019

Contributor
Suggested change
### `/log` (_In the future_)
### `/logs` (_In the future_)

I think it will be plural. Like metrics and resources

This comment has been minimized.

Copy link
@songy23

songy23 Jun 10, 2019

Contributor

I think log (singular) is a convention as package name? /cc @reyang

@SergeyKanzhelev
Copy link
Contributor

left a comment

Generally great. Few suggestions, please fix before this can be merged

@songy23
Copy link
Contributor

left a comment

LGTM overall

@mayurkale22 mayurkale22 referenced this pull request Jun 10, 2019

Merged

Initial skeleton #2

@mayurkale22 mayurkale22 force-pushed the mayurkale22:package_structure branch from d36823c to 84c835b Jun 10, 2019

@reyang

reyang approved these changes Jun 10, 2019

Copy link

left a comment

LGTM.

@SergeyKanzhelev SergeyKanzhelev merged commit f4eac5c into open-telemetry:master Jun 10, 2019

1 check passed

cla/linuxfoundation SergeyKanzhelev authorized
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.