From 8e17fe7835cd09861b4de9a75d2399b4207e7a86 Mon Sep 17 00:00:00 2001 From: Carlos Alberto Cortez Date: Mon, 21 Sep 2020 16:55:14 +0200 Subject: [PATCH 1/6] Clarify that Setter sets values only. --- specification/context/api-propagators.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/context/api-propagators.md b/specification/context/api-propagators.md index 17aff8f1eb5..ad8155c1fb4 100644 --- a/specification/context/api-propagators.md +++ b/specification/context/api-propagators.md @@ -144,7 +144,7 @@ the base [Inject](#inject) operation. Optional arguments: -- A `Setter` invoked for each propagation key to add or remove. This is an additional +- A `Setter` invoked to set each propagation key/value pair. This is an additional argument that languages are free to define to help inject data into the carrier. #### Setter argument @@ -263,7 +263,7 @@ Required arguments: - A `Context`. - The carrier that holds propagation fields. -- The `Setter` invoked for each propagation key to add or remove. +- The `Setter` invoked to set each propagation key/value pair. ## Global Propagators From f26ada6265ad1a1fcdf8d9806a6a0dff9ef570e3 Mon Sep 17 00:00:00 2001 From: Carlos Alberto Cortez Date: Tue, 22 Sep 2020 16:06:24 +0200 Subject: [PATCH 2/6] Apply more feedback. --- specification/context/api-propagators.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/context/api-propagators.md b/specification/context/api-propagators.md index ad8155c1fb4..a3153e172c7 100644 --- a/specification/context/api-propagators.md +++ b/specification/context/api-propagators.md @@ -144,7 +144,7 @@ the base [Inject](#inject) operation. Optional arguments: -- A `Setter` invoked to set each propagation key/value pair. This is an additional +- A `Setter` to set a propagation key/value pair every time it is invoked. This is an additional argument that languages are free to define to help inject data into the carrier. #### Setter argument @@ -263,7 +263,7 @@ Required arguments: - A `Context`. - The carrier that holds propagation fields. -- The `Setter` invoked to set each propagation key/value pair. +- The `Setter` to set a propagation key/value pair every time it is invoked. ## Global Propagators From 84c3f56f7f6b6347ab28716dc1dedfa263d0e330 Mon Sep 17 00:00:00 2001 From: Carlos Alberto Cortez Date: Wed, 23 Sep 2020 19:23:22 +0200 Subject: [PATCH 3/6] Update specification/context/api-propagators.md Co-authored-by: Armin Ruech --- specification/context/api-propagators.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/context/api-propagators.md b/specification/context/api-propagators.md index a3153e172c7..0dfd73bde02 100644 --- a/specification/context/api-propagators.md +++ b/specification/context/api-propagators.md @@ -144,8 +144,8 @@ the base [Inject](#inject) operation. Optional arguments: -- A `Setter` to set a propagation key/value pair every time it is invoked. This is an additional - argument that languages are free to define to help inject data into the carrier. +- A `Setter` to set a propagation key/value pair. It might be invoked multiple times in order to set multiple pairs. + This is an additional argument that languages are free to define to help inject data into the carrier. #### Setter argument From 7b6887b885d6ac533fd281837d6704b768bc6108 Mon Sep 17 00:00:00 2001 From: Carlos Alberto Cortez Date: Wed, 23 Sep 2020 19:23:28 +0200 Subject: [PATCH 4/6] Update specification/context/api-propagators.md Co-authored-by: Armin Ruech --- specification/context/api-propagators.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/context/api-propagators.md b/specification/context/api-propagators.md index 0dfd73bde02..8c6d84a2dcf 100644 --- a/specification/context/api-propagators.md +++ b/specification/context/api-propagators.md @@ -263,7 +263,7 @@ Required arguments: - A `Context`. - The carrier that holds propagation fields. -- The `Setter` to set a propagation key/value pair every time it is invoked. +- The `Setter` to set a propagation key/value pair. It might be invoked multiple times in order to set multiple pairs. ## Global Propagators From 8c32eabd3dccfee3dd81a9d20d2b16823b463911 Mon Sep 17 00:00:00 2001 From: Carlos Alberto Cortez Date: Thu, 24 Sep 2020 15:04:27 +0200 Subject: [PATCH 5/6] Update specification/context/api-propagators.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Christian Neumüller --- specification/context/api-propagators.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/context/api-propagators.md b/specification/context/api-propagators.md index 8c6d84a2dcf..17c4285376a 100644 --- a/specification/context/api-propagators.md +++ b/specification/context/api-propagators.md @@ -263,7 +263,7 @@ Required arguments: - A `Context`. - The carrier that holds propagation fields. -- The `Setter` to set a propagation key/value pair. It might be invoked multiple times in order to set multiple pairs. +- The `Setter` to set a propagation key/value pair. Propagators MAY invoke it multiple times in order to set multiple pairs. ## Global Propagators From 52daa24a6bcbcbccd392a2ada6979f89c944809f Mon Sep 17 00:00:00 2001 From: Carlos Alberto Cortez Date: Thu, 24 Sep 2020 15:04:35 +0200 Subject: [PATCH 6/6] Update specification/context/api-propagators.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Christian Neumüller --- specification/context/api-propagators.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/context/api-propagators.md b/specification/context/api-propagators.md index 17c4285376a..f1ad34e16c2 100644 --- a/specification/context/api-propagators.md +++ b/specification/context/api-propagators.md @@ -144,7 +144,7 @@ the base [Inject](#inject) operation. Optional arguments: -- A `Setter` to set a propagation key/value pair. It might be invoked multiple times in order to set multiple pairs. +- A `Setter` to set a propagation key/value pair. Propagators MAY invoke it multiple times in order to set multiple pairs. This is an additional argument that languages are free to define to help inject data into the carrier. #### Setter argument