Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(kubernetes): update configuring auto-instrumentation for nodejs #4130

Closed
atsu85 opened this issue Mar 11, 2024 · 5 comments
Closed

doc(kubernetes): update configuring auto-instrumentation for nodejs #4130

atsu85 opened this issue Mar 11, 2024 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@atsu85
Copy link
Contributor

atsu85 commented Mar 11, 2024

What needs to be changed?
After this merged PR is released, documentation about no way to configure auto-instrumentations becomes outdated

What is the name + path of the page that needs changed?

Additional context:
It becomes outdated after the next release of opentelemetry-operator.

@cartermp
Copy link
Contributor

Thanks, so it sounds like it can be changed to say something to the effect of:

"You can include only specific instrumentations by using the OTEL_NODE_ENABLED_INSTRUMENTATIONS environment variable. For example, here's how you can include only http and nestjs-core instrumentations:

export OTEL_NODE_ENABLED_INSTRUMENTATIONS="http,nestjs-core"

"

atsu85 added a commit to atsu85/opentelemetry.io that referenced this issue Apr 11, 2024
atsu85 added a commit to atsu85/opentelemetry.io that referenced this issue Apr 12, 2024
@svrnm svrnm added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 16, 2024
@IrisDyr
Copy link

IrisDyr commented Apr 16, 2024

working on this

@IrisDyr
Copy link

IrisDyr commented Apr 16, 2024

Seems that this task was already done by @atsu85 in this PR and can be closed.

@svrnm
Copy link
Member

svrnm commented Apr 16, 2024

Ah yes, but there were some outstanding points with that PR (I assumed this issue is the follow up to that), let me double check on that.

@svrnm
Copy link
Member

svrnm commented Apr 16, 2024

Here's what's missing but indeed that should be an issue on it's own while this one here is closed, apologies for overlooking that

#4137 (comment)

(this follow up issue is a little bit more complicated since we need to see that also the JS repo will be updated accordingly)

@svrnm svrnm closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants